NO-JIRA: chore(gha): add workflow to label PRs with "review-requested" on creation #1768
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiridanek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughA new GitHub Actions workflow is added that triggers on pull request openings. It checks if the "konflux-nudge" label is absent and, if so, adds the "review-requested" label to the pull request using the GitHub REST API. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
.github/PULL_REQUEST_TEMPLATE.md (4)
12-13: Clarify checklist wording (“all points” vs “that apply”)Currently contradictory. Make both lines consistently say “applicable”.
Apply this diff:
-<!--- This PR will be merged by any repository approver when it meets all the points in the checklist --> -<!--- Go over all the following points, and put an `x` in all the boxes that apply. --> +<!--- This PR will be merged by any repository approver when it meets all applicable points in the checklist. --> +<!--- Go over all applicable points, and put an `x` in every applicable box. -->
15-17: Make checklist punctuation consistentTwo items end with a period; the last one doesn’t. Add a period for consistency.
- - [ ] The developer has manually tested the changes and verified that the changes work + - [ ] The developer has manually tested the changes and verified that the changes work.Alternative (clearer): “The developer has manually verified the changes work as intended.”
1-1: Nudge PR titles to use imperative moodBased on prior learnings/preferences, encourage imperative titles (e.g., “Add…”, “Fix…”).
-<!--- Provide a general summary of your changes in the Title above --> +<!--- Provide a concise, imperative title (e.g., "Add ..." not "Added ..."). -->
6-10: Strengthen testing guidance with concrete detailsAsk authors for exact commands, environment details, expected vs actual, and CI links to speed reviews.
<!--- see how your change affects other areas of the code, etc. --> +<!--- Include exact commands, environment details (OS/arch/cluster), expected vs actual results, and links to relevant CI jobs/logs. -->
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/PULL_REQUEST_TEMPLATE.md(1 hunks)
🧰 Additional context used
🧠 Learnings (16)
📓 Common learnings
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:59:15.788Z
Learning: jiridanek creates targeted GitHub issues for specific test quality improvements identified during PR reviews in opendatahub-io/notebooks. Issue #1268 demonstrates this by converting a review comment about insufficient tf2onnx conversion test validation into a comprehensive improvement plan with clear acceptance criteria, code examples, and ROCm-specific context.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/test/test_notebook.ipynb:112-126
Timestamp: 2025-07-08T13:21:09.150Z
Learning: jiridanek requested GitHub issue creation for notebook linting and formatting improvements during PR #1306 review, specifically to address inconsistent metadata across .ipynb files and implement systematic quality standards. This continues the established pattern of comprehensive issue creation for code quality improvements with detailed problem descriptions, multiple solution options, phased acceptance criteria, and proper context linking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for RStudio py311 Tekton push pipelines during PR #1379 review. Issue #1384 was successfully created covering two RStudio variants (CPU and CUDA) found in manifests/base/params-latest.env, with comprehensive problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:22-29
Timestamp: 2025-07-02T18:27:51.097Z
Learning: jiridanek consistently creates comprehensive follow-up GitHub issues from PR review comments in opendatahub-io/notebooks, turning specific code quality concerns into systematic improvements tracked with proper context, acceptance criteria, and cross-references. Issue #1266 demonstrates this pattern by expanding a specific error handling concern in load_expected_versions() into a repository-wide improvement initiative.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-03T13:01:18.625Z
Learning: jiridanek requested GitHub issue creation for markdown linting improvements in PR #1269, specifically addressing MD014 violations in README files while also suggesting repository-wide markdown linter integration. Issue #1290 was successfully created with comprehensive tooling recommendations, phased implementation plan, clear acceptance criteria, and systematic approach to documentation quality improvements, continuing the established pattern of systematic code quality enhancements.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review. Issue was created with comprehensive problem description covering both Python 3.11 and 3.12 versions, repository pattern analysis showing correct vs incorrect naming, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-05T17:24:08.616Z
Learning: jiridanek requested PR review for #1521 covering s390x architecture support improvements, demonstrating continued focus on systematic multi-architecture compatibility enhancements in the opendatahub-io/notebooks repository through clean implementation with centralized configuration, proper CI integration, and architecture-aware testing patterns.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-01T14:46:03.215Z
Learning: jiridanek requested GitHub issue creation for two nitpicks during PR #1588 review: comment wording improvement in ROCm TensorFlow Dockerfile and typo fix in Jupyter DataScience Dockerfile stage header. Issues #1589 and #1590 were successfully created with comprehensive problem descriptions, specific file locations and line numbers, clear before/after solutions, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review, affecting both Python 3.11 and 3.12 versions. Issue #1338 was created with comprehensive problem description covering both affected images, repository pattern analysis comparing correct vs incorrect naming conventions, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1379
File: .tekton/odh-workbench-jupyter-datascience-cpu-py312-ubi9-push.yaml:14-17
Timestamp: 2025-07-11T11:15:47.424Z
Learning: jiridanek requested GitHub issue creation for CEL filter problem in datascience workbench Tekton pipelines during PR #1379 review. Issue #1383 was successfully created with comprehensive problem description covering both Python 3.11 and 3.12 pipelines incorrectly watching jupyter/minimal directories instead of jupyter/datascience directories, detailed impact analysis of pipeline execution failures, complete solution with before/after code examples, thorough acceptance criteria for path updates and pipeline triggering verification, implementation notes about repository structure alignment, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-03T13:01:18.625Z
Learning: jiridanek requested GitHub issue creation for markdown linting improvements in PR #1269, specifically addressing MD014 violations in README files and suggesting repository-wide markdown linter integration. Issue #1290 was created with comprehensive tooling recommendations, implementation phases, acceptance criteria, and systematic approach to documentation quality improvements.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for adding RStudio py311 Tekton push pipelines during PR #1379 review, referencing existing registry entries in manifests/base/params-latest.env but missing corresponding .tekton pipeline files. A comprehensive issue was created with detailed problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1425
File: .github/workflows/security.yaml:23-32
Timestamp: 2025-07-22T06:00:47.032Z
Learning: jiridanek requested GitHub issue creation for Trivy security scan enforcement during PR #1425 review, specifically addressing the exit-code: '0' configuration that prevents the security workflow from failing on detected vulnerabilities. Issue #1427 was successfully created with comprehensive problem description covering security gate bypass risks, multiple solution options (immediate, phased, critical-only enforcement), detailed phased acceptance criteria, implementation guidance with testing approach, risk mitigation strategies, and proper context linking, continuing the established pattern of systematic security improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1269
File: codeserver/ubi9-python-3.12/nginx/root/usr/share/container-scripts/nginx/common.sh:1-3
Timestamp: 2025-07-03T12:07:19.365Z
Learning: jiridanek consistently requests GitHub issue creation for technical improvements identified during code reviews in opendatahub-io/notebooks, ensuring systematic tracking of code quality enhancements like shell script portability issues with comprehensive descriptions, solution options, and acceptance criteria.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#968
File: codeserver/ubi9-python-3.11/Dockerfile.cpu:138-140
Timestamp: 2025-08-01T16:07:58.701Z
Learning: jiridanek prefers architectural solutions that eliminate problems entirely rather than just fixing immediate technical issues. When presented with a pipeline safety concern about micropipenv requirements generation, he suggested removing micropipenv from the build process altogether by using pre-committed requirements.txt files, demonstrating preference for simplification and deterministic builds over complex workarounds.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1600
File: Makefile:0-0
Timestamp: 2025-08-02T08:49:03.735Z
Learning: jiridanek decided to eliminate '+' characters entirely from Makefile target names during PR #1600 review instead of implementing complex substitution workarounds, demonstrating his consistent preference for architectural solutions that eliminate problems at the source rather than adding complexity to handle edge cases.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1269
File: codeserver/ubi9-python-3.12/utils/process.sh:17-19
Timestamp: 2025-07-03T14:00:00.909Z
Learning: jiridanek efficiently identifies when CodeRabbit review suggestions are already covered by existing comprehensive issues, demonstrating excellent issue management and avoiding duplicate tracking of the same improvements across multiple locations.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1151
File: jupyter/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:31-34
Timestamp: 2025-07-01T07:03:05.385Z
Learning: jiridanek demonstrates excellent pattern recognition for identifying duplicated code issues across the opendatahub-io/notebooks repository. When spotting a potential problem in test notebooks, he correctly assesses that such patterns are likely replicated across multiple similar files rather than being isolated incidents, leading to more effective systematic solutions.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/Dockerfile.rocm:56-66
Timestamp: 2025-07-02T18:19:49.397Z
Learning: jiridanek consistently creates comprehensive follow-up GitHub issues for security concerns raised during PR reviews in opendatahub-io/notebooks, ensuring systematic tracking and resolution of supply-chain security improvements like GPG signature verification for package repositories.
📚 Learning: 2025-07-03T13:01:18.625Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-03T13:01:18.625Z
Learning: jiridanek requested GitHub issue creation for markdown linting improvements in PR #1269, specifically addressing MD014 violations in README files while also suggesting repository-wide markdown linter integration. Issue #1290 was successfully created with comprehensive tooling recommendations, phased implementation plan, clear acceptance criteria, and systematic approach to documentation quality improvements, continuing the established pattern of systematic code quality enhancements.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-09T14:41:52.874Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-09T14:41:52.874Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-11T11:16:05.131Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for RStudio py311 Tekton push pipelines during PR #1379 review. Issue #1384 was successfully created covering two RStudio variants (CPU and CUDA) found in manifests/base/params-latest.env, with comprehensive problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-18T07:20:47.031Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-18T07:20:47.031Z
Learning: jiridanek requested GitHub issue creation for GOPATH preservation problem in GitHub Actions workflow template during PR #1407 review. Issue #1411 was successfully created with comprehensive problem description covering sudo --preserve-env=PATH dropping GOPATH environment variable causing Go toolchain to recompile binaries unnecessarily, detailed impact analysis of performance degradation and permission pollution, multiple solution options (preserving GOPATH, GOMODCACHE, or removing sudo), clear acceptance criteria for optimization validation, implementation guidance with testing recommendations, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-03T13:01:18.625Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-03T13:01:18.625Z
Learning: jiridanek requested GitHub issue creation for markdown linting improvements in PR #1269, specifically addressing MD014 violations in README files and suggesting repository-wide markdown linter integration. Issue #1290 was created with comprehensive tooling recommendations, implementation phases, acceptance criteria, and systematic approach to documentation quality improvements.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-08-04T15:54:27.087Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1629
File: scripts/buildinputs/buildinputs.go:11-21
Timestamp: 2025-08-04T15:54:27.087Z
Learning: jiridanek requested GitHub issue creation for TARGETPLATFORM environment variable validation bug during PR #1629 review. Issue #1631 was successfully created with comprehensive problem description covering empty/unset TARGETPLATFORM causing misleading panic messages in buildinputs tool, detailed root cause analysis showing strings.Split("", "/") behavior, impact analysis of pipeline failures, proposed solution with explicit empty string validation, clear acceptance criteria for error message improvements, implementation guidance for actionable developer feedback, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-11T11:16:05.131Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for adding RStudio py311 Tekton push pipelines during PR #1379 review, referencing existing registry entries in manifests/base/params-latest.env but missing corresponding .tekton pipeline files. A comprehensive issue was created with detailed problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-08T13:21:09.150Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/test/test_notebook.ipynb:112-126
Timestamp: 2025-07-08T13:21:09.150Z
Learning: jiridanek requested GitHub issue creation for notebook linting and formatting improvements during PR #1306 review, specifically to address inconsistent metadata across .ipynb files and implement systematic quality standards. This continues the established pattern of comprehensive issue creation for code quality improvements with detailed problem descriptions, multiple solution options, phased acceptance criteria, and proper context linking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-08T19:09:48.746Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review. Issue was created with comprehensive problem description covering both Python 3.11 and 3.12 versions, repository pattern analysis showing correct vs incorrect naming, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-02T18:59:15.788Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:59:15.788Z
Learning: jiridanek creates targeted GitHub issues for specific test quality improvements identified during PR reviews in opendatahub-io/notebooks. Issue #1268 demonstrates this by converting a review comment about insufficient tf2onnx conversion test validation into a comprehensive improvement plan with clear acceptance criteria, code examples, and ROCm-specific context.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-08T19:09:48.746Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review, affecting both Python 3.11 and 3.12 versions. Issue #1338 was created with comprehensive problem description covering both affected images, repository pattern analysis comparing correct vs incorrect naming conventions, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-06-19T06:29:29.217Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-06-19T06:29:29.217Z
Learning: PR titles should use imperative mood (e.g., "Add feature" not "Created feature") and be concise while clearly describing what the change accomplishes. Ticket references can be maintained at the beginning while following imperative mood for the descriptive part.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-08-01T14:46:03.215Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-01T14:46:03.215Z
Learning: jiridanek requested GitHub issue creation for two nitpicks during PR #1588 review: comment wording improvement in ROCm TensorFlow Dockerfile and typo fix in Jupyter DataScience Dockerfile stage header. Issues #1589 and #1590 were successfully created with comprehensive problem descriptions, specific file locations and line numbers, clear before/after solutions, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
📚 Learning: 2025-07-22T08:09:26.141Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1436
File: .github/workflows/build-notebooks-TEMPLATE.yaml:542-542
Timestamp: 2025-07-22T08:09:26.141Z
Learning: jiridanek requested GitHub issue creation for Firefox Playwright test reliability problem during PR #1436 review. Issue was successfully created with comprehensive problem description covering VS Code command palette race conditions in executeCommandViaMenus() method, detailed root cause analysis of DOM update timing sensitivity in Firefox, four solution options (retry logic, specific selectors, enhanced diagnostics, keyboard navigation) with complete code examples, clear acceptance criteria for reliability and cross-browser compatibility, testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/PULL_REQUEST_TEMPLATE.md
🪛 markdownlint-cli2 (0.17.2)
.github/PULL_REQUEST_TEMPLATE.md
11-11: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
jiridanek
added
the
review-requested
|
we are not |
|
in any case, I did not figure out how to make prow set it |
|
Got it, seems will never work with prow... |
jiridanek
force-pushed
the
jiridanek-patch-1
branch
from
4d703da to
d4d97e6
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
.github/workflows/notify-team-to-review-pr.yml (3)
11-11: Make condition robust and idempotent.Avoid re-adding the label and hardening the contains check makes the job cleaner.
- if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false + if: > + !contains(join(github.event.pull_request.labels.*.name, ','), 'konflux-nudge') + && !contains(join(github.event.pull_request.labels.*.name, ','), 'review-requested')
2-4: Consider pull_request_target (with caution) and broader triggers.If you want labels added for PRs from forks, pull_request won’t have a writable token. pull_request_target does, and is safe here since no PR code runs. Also include reopened/synchronize to handle PR updates.
-on: - pull_request: - types: [opened] +on: + pull_request_target: + types: [opened, reopened, synchronize]Note: Keep steps free of untrusted PR code (as you do) when using pull_request_target.
14-24: Align label with PR objective and make it configurable.PR intent mentions pr-review-ai-ide-team; current code applies review-requested. Either switch to the intended label or make it configurable to accommodate naming updates (e.g., aaiet).
add-label: + env: + LABEL_NAME: pr-review-ai-ide-team steps: - name: Add review-requested label - uses: actions/github-script@v6 + uses: actions/github-script@v7 with: # language=javascript script: | await github.rest.issues.addLabels({ owner: context.repo.owner, repo: context.repo.repo, issue_number: context.payload.pull_request.number, - labels: ['review-requested'] + labels: [process.env.LABEL_NAME] });If the repository label doesn’t exist, this will 422. If desired, I can add a preceding step to create the label when missing.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/notify-team-to-review-pr.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review. Issue was created with comprehensive problem description covering both Python 3.11 and 3.12 versions, repository pattern analysis showing correct vs incorrect naming, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:59:15.788Z
Learning: jiridanek creates targeted GitHub issues for specific test quality improvements identified during PR reviews in opendatahub-io/notebooks. Issue #1268 demonstrates this by converting a review comment about insufficient tf2onnx conversion test validation into a comprehensive improvement plan with clear acceptance criteria, code examples, and ROCm-specific context.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-01T14:46:03.215Z
Learning: jiridanek requested GitHub issue creation for two nitpicks during PR #1588 review: comment wording improvement in ROCm TensorFlow Dockerfile and typo fix in Jupyter DataScience Dockerfile stage header. Issues #1589 and #1590 were successfully created with comprehensive problem descriptions, specific file locations and line numbers, clear before/after solutions, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for RStudio py311 Tekton push pipelines during PR #1379 review. Issue #1384 was successfully created covering two RStudio variants (CPU and CUDA) found in manifests/base/params-latest.env, with comprehensive problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/test/test_notebook.ipynb:112-126
Timestamp: 2025-07-08T13:21:09.150Z
Learning: jiridanek requested GitHub issue creation for notebook linting and formatting improvements during PR #1306 review, specifically to address inconsistent metadata across .ipynb files and implement systematic quality standards. This continues the established pattern of comprehensive issue creation for code quality improvements with detailed problem descriptions, multiple solution options, phased acceptance criteria, and proper context linking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review, affecting both Python 3.11 and 3.12 versions. Issue #1338 was created with comprehensive problem description covering both affected images, repository pattern analysis comparing correct vs incorrect naming conventions, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:22-29
Timestamp: 2025-07-02T18:27:51.097Z
Learning: jiridanek consistently creates comprehensive follow-up GitHub issues from PR review comments in opendatahub-io/notebooks, turning specific code quality concerns into systematic improvements tracked with proper context, acceptance criteria, and cross-references. Issue #1266 demonstrates this pattern by expanding a specific error handling concern in load_expected_versions() into a repository-wide improvement initiative.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T09:12:44.088Z
Learning: jiridanek requested GitHub issue creation for GitHub Actions artifact naming conflict during PR #1357 review, specifically for a failing actions/upload-artifactv4 step with 409 Conflict error. Issue was created with comprehensive problem description covering artifact naming conflicts, root cause analysis of duplicate names in concurrent workflows, four solution options (enhanced naming, overwriting, conditional uploads, matrix-aware naming) with code examples, detailed acceptance criteria, implementation guidance, testing approach, and proper context linking, continuing the established pattern of systematic CI/CD and code quality improvements through detailed issue tracking.
📚 Learning: 2025-07-09T14:41:52.874Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-09T14:41:52.874Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-09T09:12:44.088Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T09:12:44.088Z
Learning: jiridanek requested GitHub issue creation for GitHub Actions artifact naming conflict during PR #1357 review, specifically for a failing actions/upload-artifactv4 step with 409 Conflict error. Issue was created with comprehensive problem description covering artifact naming conflicts, root cause analysis of duplicate names in concurrent workflows, four solution options (enhanced naming, overwriting, conditional uploads, matrix-aware naming) with code examples, detailed acceptance criteria, implementation guidance, testing approach, and proper context linking, continuing the established pattern of systematic CI/CD and code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
🪛 actionlint (1.7.7)
.github/workflows/notify-team-to-review-pr.yml
15-15: the runner of "actions/github-script@v6" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
jiridanek
added
review-requested
…" on creation This can then be tied up with the Slack notification mechanism, so that we aren't spammed by konflux-nudge PRs. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
jiridanek
force-pushed
the
jiridanek-patch-1
branch
from
bdb29ea to
27a13bf
Compare
jiridanek
changed the title
/label pr-review-ai-ide-team
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/notify-team-to-review-pr.yml (2)
3-6: Optional: also handle draft→ready and reopen events.If you want the label when drafts are made ready or when PRs are reopened, extend types:
on: - pull_request: - types: [opened] + pull_request: + types: [opened, ready_for_review, reopened]
15-25: Idempotency and minor cleanup.
- Skip the API call if the label is already present to avoid no-op calls:
steps: - name: Add review-requested label - uses: actions/github-script@v7 + if: !contains(github.event.pull_request.labels.*.name, 'review-requested') + uses: actions/github-script@v7
- Slightly simpler PR number access:
- issue_number: context.payload.pull_request.number, + issue_number: context.issue.number,Note: Ensure the
review-requestedlabel exists in the repo (pre-created with desired color/description) to avoid failures under least-privilege permissions.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/notify-team-to-review-pr.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (17)
📓 Common learnings
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T09:12:44.088Z
Learning: jiridanek requested GitHub issue creation for GitHub Actions artifact naming conflict during PR #1357 review, specifically for a failing actions/upload-artifactv4 step with 409 Conflict error. Issue was created with comprehensive problem description covering artifact naming conflicts, root cause analysis of duplicate names in concurrent workflows, four solution options (enhanced naming, overwriting, conditional uploads, matrix-aware naming) with code examples, detailed acceptance criteria, implementation guidance, testing approach, and proper context linking, continuing the established pattern of systematic CI/CD and code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-01T14:46:03.215Z
Learning: jiridanek requested GitHub issue creation for two nitpicks during PR #1588 review: comment wording improvement in ROCm TensorFlow Dockerfile and typo fix in Jupyter DataScience Dockerfile stage header. Issues #1589 and #1590 were successfully created with comprehensive problem descriptions, specific file locations and line numbers, clear before/after solutions, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/test/test_notebook.ipynb:112-126
Timestamp: 2025-07-08T13:21:09.150Z
Learning: jiridanek requested GitHub issue creation for notebook linting and formatting improvements during PR #1306 review, specifically to address inconsistent metadata across .ipynb files and implement systematic quality standards. This continues the established pattern of comprehensive issue creation for code quality improvements with detailed problem descriptions, multiple solution options, phased acceptance criteria, and proper context linking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-18T07:20:47.031Z
Learning: jiridanek requested GitHub issue creation for GOPATH preservation problem in GitHub Actions workflow template during PR #1407 review. Issue #1411 was successfully created with comprehensive problem description covering sudo --preserve-env=PATH dropping GOPATH environment variable causing Go toolchain to recompile binaries unnecessarily, detailed impact analysis of performance degradation and permission pollution, multiple solution options (preserving GOPATH, GOMODCACHE, or removing sudo), clear acceptance criteria for optimization validation, implementation guidance with testing recommendations, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:22-29
Timestamp: 2025-07-02T18:27:51.097Z
Learning: jiridanek consistently creates comprehensive follow-up GitHub issues from PR review comments in opendatahub-io/notebooks, turning specific code quality concerns into systematic improvements tracked with proper context, acceptance criteria, and cross-references. Issue #1266 demonstrates this pattern by expanding a specific error handling concern in load_expected_versions() into a repository-wide improvement initiative.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1425
File: .github/workflows/security.yaml:23-32
Timestamp: 2025-07-22T06:00:47.032Z
Learning: jiridanek requested GitHub issue creation for Trivy security scan enforcement during PR #1425 review, specifically addressing the exit-code: '0' configuration that prevents the security workflow from failing on detected vulnerabilities. Issue #1427 was successfully created with comprehensive problem description covering security gate bypass risks, multiple solution options (immediate, phased, critical-only enforcement), detailed phased acceptance criteria, implementation guidance with testing approach, risk mitigation strategies, and proper context linking, continuing the established pattern of systematic security improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for RStudio py311 Tekton push pipelines during PR #1379 review. Issue #1384 was successfully created covering two RStudio variants (CPU and CUDA) found in manifests/base/params-latest.env, with comprehensive problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-05T17:24:08.616Z
Learning: jiridanek requested PR review for #1521 covering s390x architecture support improvements, demonstrating continued focus on systematic multi-architecture compatibility enhancements in the opendatahub-io/notebooks repository through clean implementation with centralized configuration, proper CI integration, and architecture-aware testing patterns.
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1768
File: .github/workflows/notify-team-to-review-pr.yml:6-7
Timestamp: 2025-08-10T17:18:32.242Z
Learning: When using the `github.rest.issues.addLabels` API to add labels to pull requests in GitHub Actions workflows, either `issues: write` OR `pull-requests: write` permission is sufficient. For pull requests specifically, `pull-requests: write` is the preferred permission following the principle of least privilege, even though the API endpoint is part of the Issues API.
📚 Learning: 2025-07-09T14:41:52.874Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue was created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-09T14:41:52.874Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .github/workflows/insta-merge.yaml:1-1
Timestamp: 2025-07-09T14:41:52.874Z
Learning: jiridanek requested GitHub issue creation for YAML linting problems caused by the new GitHub Actions workflow in PR #1365, specifically addressing failures in the repository's YAML linter due to the insta-merge.yaml workflow file. Issue #1370 was successfully created with comprehensive problem description covering potential indentation, quoting, line length, and structural issues, detailed root cause analysis, four solution options (fixing current file, implementing linting rules, automated formatting, repository-wide standardization), clear acceptance criteria, implementation guidance with testing approach, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-09T09:12:44.088Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-09T09:12:44.088Z
Learning: jiridanek requested GitHub issue creation for GitHub Actions artifact naming conflict during PR #1357 review, specifically for a failing actions/upload-artifactv4 step with 409 Conflict error. Issue was created with comprehensive problem description covering artifact naming conflicts, root cause analysis of duplicate names in concurrent workflows, four solution options (enhanced naming, overwriting, conditional uploads, matrix-aware naming) with code examples, detailed acceptance criteria, implementation guidance, testing approach, and proper context linking, continuing the established pattern of systematic CI/CD and code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-08-10T17:18:32.242Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1768
File: .github/workflows/notify-team-to-review-pr.yml:6-7
Timestamp: 2025-08-10T17:18:32.242Z
Learning: When using the `github.rest.issues.addLabels` API to add labels to pull requests in GitHub Actions workflows, either `issues: write` OR `pull-requests: write` permission is sufficient. For pull requests specifically, `pull-requests: write` is the preferred permission following the principle of least privilege, even though the API endpoint is part of the Issues API.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-11T11:16:05.131Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for RStudio py311 Tekton push pipelines during PR #1379 review. Issue #1384 was successfully created covering two RStudio variants (CPU and CUDA) found in manifests/base/params-latest.env, with comprehensive problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-11T11:16:05.131Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-11T11:16:05.131Z
Learning: jiridanek requested GitHub issue creation for adding RStudio py311 Tekton push pipelines during PR #1379 review, referencing existing registry entries in manifests/base/params-latest.env but missing corresponding .tekton pipeline files. A comprehensive issue was created with detailed problem description, implementation requirements following the same pattern as other workbench pipelines, clear acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-08T19:09:48.746Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review. Issue was created with comprehensive problem description covering both Python 3.11 and 3.12 versions, repository pattern analysis showing correct vs incorrect naming, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-11T11:15:47.424Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1379
File: .tekton/odh-workbench-jupyter-datascience-cpu-py312-ubi9-push.yaml:14-17
Timestamp: 2025-07-11T11:15:47.424Z
Learning: jiridanek requested GitHub issue creation for CEL filter problem in datascience workbench Tekton pipelines during PR #1379 review. Issue #1383 was successfully created with comprehensive problem description covering both Python 3.11 and 3.12 pipelines incorrectly watching jupyter/minimal directories instead of jupyter/datascience directories, detailed impact analysis of pipeline execution failures, complete solution with before/after code examples, thorough acceptance criteria for path updates and pipeline triggering verification, implementation notes about repository structure alignment, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-11T11:15:25.572Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1379
File: .tekton/odh-workbench-jupyter-pytorch-cuda-py312-ubi9-push.yaml:40-44
Timestamp: 2025-07-11T11:15:25.572Z
Learning: jiridanek requested GitHub issue creation for critical Tekton array parameter syntax error during PR #1379 review, affecting all 32 pipeline files with additional-tags parameter. Issue #1382 was created with comprehensive problem description covering both Python 3.11 and 3.12 pipeline files (16 each), detailed root cause analysis of value: vs values: syntax error, critical impact assessment of complete pipeline execution failure, complete list of all affected files across workbench and runtime types, implementation commands with sed scripts, detailed acceptance criteria, implementation notes about systematic copy-paste error propagation, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-08T19:09:48.746Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1306
File: jupyter/trustyai/ubi9-python-3.12/kustomize/base/kustomization.yaml:8-12
Timestamp: 2025-07-08T19:09:48.746Z
Learning: jiridanek requested GitHub issue creation for misleading CUDA prefix in TrustyAI image tags during PR #1306 review, affecting both Python 3.11 and 3.12 versions. Issue #1338 was created with comprehensive problem description covering both affected images, repository pattern analysis comparing correct vs incorrect naming conventions, clear solution with code examples, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-02T18:27:51.097Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb:22-29
Timestamp: 2025-07-02T18:27:51.097Z
Learning: jiridanek consistently creates comprehensive follow-up GitHub issues from PR review comments in opendatahub-io/notebooks, turning specific code quality concerns into systematic improvements tracked with proper context, acceptance criteria, and cross-references. Issue #1266 demonstrates this pattern by expanding a specific error handling concern in load_expected_versions() into a repository-wide improvement initiative.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-08-01T14:46:03.215Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-01T14:46:03.215Z
Learning: jiridanek requested GitHub issue creation for two nitpicks during PR #1588 review: comment wording improvement in ROCm TensorFlow Dockerfile and typo fix in Jupyter DataScience Dockerfile stage header. Issues #1589 and #1590 were successfully created with comprehensive problem descriptions, specific file locations and line numbers, clear before/after solutions, detailed acceptance criteria, and proper context linking, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-02T18:59:15.788Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1259
File: jupyter/rocm/tensorflow/ubi9-python-3.12/kustomize/base/service.yaml:5-15
Timestamp: 2025-07-02T18:59:15.788Z
Learning: jiridanek creates targeted GitHub issues for specific test quality improvements identified during PR reviews in opendatahub-io/notebooks. Issue #1268 demonstrates this by converting a review comment about insufficient tf2onnx conversion test validation into a comprehensive improvement plan with clear acceptance criteria, code examples, and ROCm-specific context.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-09T15:10:16.532Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#1365
File: .tekton/odh-workbench-jupyter-pytorch-rocm-py311-ubi9-push.yaml:9-9
Timestamp: 2025-07-09T15:10:16.532Z
Learning: jiridanek requested GitHub issue creation for YAML syntax error in Tekton PipelineRun during PR #1365 review. Issue #1371 was successfully created with comprehensive problem description covering trailing backslash causing YAML parser failure, technical details with specific error messages, impact analysis of pipeline execution breakdown, clear solution with code examples, detailed acceptance criteria, and proper notification to riprasad about automation failure, continuing the established pattern of systematic code quality improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-08-05T17:24:08.616Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-08-05T17:24:08.616Z
Learning: jiridanek requested PR review for #1521 covering s390x architecture support improvements, demonstrating continued focus on systematic multi-architecture compatibility enhancements in the opendatahub-io/notebooks repository through clean implementation with centralized configuration, proper CI integration, and architecture-aware testing patterns.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
📚 Learning: 2025-07-22T07:30:12.760Z
Learnt from: jiridanek
PR: opendatahub-io/notebooks#0
File: :0-0
Timestamp: 2025-07-22T07:30:12.760Z
Learning: jiridanek requested GitHub issue creation for GitHub Actions LVM setup failure during PR #1425 review, specifically addressing ext4 signature detection causing lvcreate to fail with interactive prompts. Issue #1434 was successfully created with comprehensive problem description covering stale filesystem signatures, interactive prompt failures, runner cleanup issues, disk space pressure, detailed technical analysis, multiple solution options (immediate signature wiping, robust pre-cleanup logic, enhanced runner cleanup, alternative volume strategies), clear acceptance criteria, implementation guidance, risk mitigation strategies, and proper context linking. This infrastructure issue is related to but distinct from existing Issue #1196 about fallocate failures in the same gha_lvm_overlay.sh script, continuing the established pattern of systematic infrastructure improvements through detailed issue tracking.
Applied to files:
.github/workflows/notify-team-to-review-pr.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (rocm-jupyter-minimal-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rstudio-c9s-python-3.11, 3.11, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.11, 3.11, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-ubi9-python-3.11, 3.11, linux/amd64, false) / build
- GitHub Check: build (jupyter-datascience-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-minimal-ubi9-python-3.11, 3.11, linux/arm64, false) / build
- GitHub Check: build (runtime-minimal-ubi9-python-3.12, 3.12, linux/s390x, false) / build
- GitHub Check: build (jupyter-trustyai-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (rstudio-rhel9-python-3.11, 3.11, linux/amd64, true) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (cuda-rstudio-c9s-python-3.11, 3.11, linux/amd64, false) / build
- GitHub Check: build (cuda-jupyter-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-pytorch-llmcompressor-ubi9-python-3.11, 3.11, linux/amd64, false) / build
- GitHub Check: build (runtime-cuda-tensorflow-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: build (cuda-rstudio-rhel9-python-3.11, 3.11, linux/amd64, true) / build
- GitHub Check: build (jupyter-trustyai-ubi9-python-3.11, 3.11, linux/amd64, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.11, 3.11, linux/arm64, false) / build
🔇 Additional comments (1)
.github/workflows/notify-team-to-review-pr.yml (1)
7-8: Least-privilege permission is correct.Using
pull-requests: writeis sufficient and preferred for adding labels on PRs. LGTM.
Comment on lines
+3
to
+6
| on: # yamllint disable-line rule:truthy | ||
| pull_request: | ||
| types: [opened] | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Fork support: consider pull_request_target or skip forks.
With pull_request, PRs from forks get a read-only token and labeling will fail (“Resource not accessible by integration”). Two safe options:
- Switch to
pull_request_target(no checkout of fork code here, so safe), or - Keep
pull_requestand skip forks to avoid failures.
Example diffs:
Option A (preferred for labeling forks):
-on:
- pull_request:
- types: [opened]
+on:
+ pull_request_target:
+ types: [opened]Option B (skip forks cleanly):
jobs:
add-label:
- if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false
+ if: github.event.pull_request.head.repo.fork == false &&
+ contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false🏁 Script executed:
#!/bin/bash
set -e
echo "=== Workflow File Preview (.github/workflows/notify-team-to-review-pr.yml) ==="
sed -n '1,200p' .github/workflows/notify-team-to-review-pr.yml || true
echo ""
echo "=== Searching for 'label' occurrences in the workflow ==="
grep -R "label" -n .github/workflows/notify-team-to-review-pr.yml || trueLength of output: 1331
Ensure forked PRs can be labeled
Your workflow currently triggers on pull_request, which provides a read-only GITHUB_TOKEN for forked PRs—causing the addLabels call to fail. You can fix this by either:
• Switching the trigger to pull_request_target (preferred), since it runs in the base repo with write permissions.
• Or keeping pull_request and guarding the job to run only on non-forks.
Locations to update:
.github/workflows/notify-team-to-review-pr.yml– change theon:block or the job’sif:condition as shown below.
Option A (preferred – write token on forks):
-on:
- pull_request:
- types: [opened]
+on:
+ pull_request_target:
+ types: [opened]Option B (skip forks):
jobs:
add-label:
- if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false
+ if: github.event.pull_request.head.repo.fork == false &&
+ contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false🤖 Prompt for AI Agents
In .github/workflows/notify-team-to-review-pr.yml around lines 3 to 6, the
workflow triggers on pull_request which provides a read-only GITHUB_TOKEN for
forked PRs, causing label addition to fail. Fix this by changing the trigger
from pull_request to pull_request_target to run with write permissions on the
base repo, or alternatively, keep pull_request but add a job-level condition to
skip runs on forked PRs. Update the on: block or add an if: condition
accordingly to ensure the workflow can label forked PRs.
Comment on lines
+12
to
+13
| if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add a second guard to avoid mislabeling konflux PRs.
Relying solely on the presence of the konflux-nudge label at “opened” can race if that label isn’t present yet. Add an author guard too:
- if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false
+ if: github.actor != 'red-hat-konflux' &&
+ !contains(github.event.pull_request.labels.*.name, 'konflux-nudge')Also simplified == false to !….
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if: contains(github.event.pull_request.labels.*.name, 'konflux-nudge') == false | |
| runs-on: ubuntu-latest | |
| if: github.actor != 'red-hat-konflux' && | |
| !contains(github.event.pull_request.labels.*.name, 'konflux-nudge') | |
| runs-on: ubuntu-latest |
🤖 Prompt for AI Agents
In .github/workflows/notify-team-to-review-pr.yml at lines 12-13, the condition
only checks if the 'konflux-nudge' label is absent, which can cause race
conditions. Add an additional guard to check the PR author to avoid mislabeling
konflux PRs. Also, simplify the condition by replacing '== false' with a
negation operator '!'. Update the if condition to combine both checks properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows @atheo89 's suggestion to set the label using Github Actions Workflow instead of using the PR TEMPLATE file and Prow as I intended originally.
The problem being solved is that Slack currently spams the PR notification channel with konflux-nudge PRs, which is distracting.
How Has This Been Tested?
Check that the GHA works to set the label
Check that the slack commands work to subscribe the repo correctly
Merge criteria:
Summary by CodeRabbit
Summary by CodeRabbit