-
Notifications
You must be signed in to change notification settings - Fork 113
Changes to remove EPEL from final image of Codeserver #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Md. Shafi Hussain <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughRemoved EPEL/lcms-related installs for ppc64le in Dockerfile. Updated devel_env_setup.sh: added build_pillow function, adjusted build_pyarrow to use provided version, installed patchelf on ppc64le, parsed Pillow version from pylock.toml, and built Pillow wheel before installing wheels. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
/build-konflux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
codeserver/ubi9-python-3.12/Dockerfile.cpu
(0 hunks)codeserver/ubi9-python-3.12/devel_env_setup.sh
(3 hunks)
💤 Files with no reviewable changes (1)
- codeserver/ubi9-python-3.12/Dockerfile.cpu
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/arm64, false) / build
- GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/amd64, false) / build
- GitHub Check: Red Hat Konflux / odh-workbench-codeserver-datascience-cpu-py312-ubi9-on-pull-request
: ================= Fix Pillow Wheel ==================== | ||
cd /pillowwheel | ||
uv pip install auditwheel | ||
auditwheel repair pillow*.whl | ||
mv wheelhouse/pillow*.whl ${WHEEL_DIR} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix Pillow wheel glob (build currently aborts).
auditwheel
emits Pillow-...whl
(capital P), so mv wheelhouse/pillow*.whl
never matches. With set -e
, the build stops here and no wheels make it into WHEEL_DIR
. Please switch the glob to wheelhouse/Pillow*.whl
(or *.whl
) so the move succeeds.
🤖 Prompt for AI Agents
In codeserver/ubi9-python-3.12/devel_env_setup.sh around lines 25 to 30, the mv
command uses a lowercase glob that never matches auditwheel's output
(Pillow-*.whl) causing the script to abort; change the move to use a matching
glob such as wheelhouse/Pillow*.whl (or wheelhouse/*.whl) so the files are
actually moved into ${WHEEL_DIR}; ensure the mv line is updated accordingly and
consider leaving the glob broad enough to catch any capitalization variants.
@Shafi-Hussain: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/build-konflux |
Description
Having EPEL repo enabled for ppc64le images raises alerts with Conforma.
The libraries coming from EPEL are needed by Pillow which gets built from source on ppc64le arch.
To avoid installation of libraries from EPEL, we build Pillow and repair the wheel to bundle all the necessary libraries in the wheel itself.
How Has This Been Tested?
Self checklist (all need to be checked):
make test
(gmake
on macOS) before asking for reviewDockerfile.konflux
files should be done inodh/notebooks
and automatically synced torhds/notebooks
. For Konflux-specific changes, modifyDockerfile.konflux
files directly inrhds/notebooks
as these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Summary by CodeRabbit
New Features
Bug Fixes
Chores