Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

codeserver/ubi9-python-3.12/devel_env_setup.sh (6)

27-29: Avoid persisting auditwheel; run it via uvx.

Installing auditwheel into the image is unnecessary; use uvx to run it transiently.

-    uv pip install auditwheel
-    auditwheel repair pillow*.whl
+    uvx --from auditwheel auditwheel repair pillow*.whl

---

97-101: Version parsing from pylock.toml is fragile (drops rc/post/local).

The regex only captures digits/dots; pre-releases (rc), post releases, or locals will be misparsed. Use tomllib to read TOML reliably.

Example replacement (adjust keys to your actual lock schema):

-    PYARROW_VERSION=$(grep -A1 '"pyarrow"' pylock.toml | grep -Eo '\b[0-9\.]+\b')
+    PYARROW_VERSION=$(python - <<'PY'
+import tomllib, sys
+with open("pylock.toml","rb") as f:
+    d = tomllib.load(f)
+# Adapt this lookup to your lock structure:
+def find(pkg):
+    # common patterns: {'package':[{'name':'pyarrow','version':'X'}]}
+    for key,val in d.items():
+        if isinstance(val, list):
+            for it in val:
+                if isinstance(it, dict) and it.get("name")==pkg and "version" in it:
+                    return it["version"]
+    raise SystemExit(f"version for {pkg} not found")
+print(find("pyarrow"))
+PY
+)
-    PILLOW_VERSION=$(grep -A1 '"pillow"' pylock.toml | grep -Eo '\b[0-9\.]+\b')
+    PILLOW_VERSION=$(python - <<'PY'
+import tomllib, sys
+with open("pylock.toml","rb") as f:
+    d = tomllib.load(f)
+def find(pkg):
+    for key,val in d.items():
+        if isinstance(val, list):
+            for it in val:
+                if isinstance(it, dict) and it.get("name")==pkg and "version" in it:
+                    return it["version"]
+    raise SystemExit(f"version for {pkg} not found")
+print(find("pillow"))
+PY
+)

If the structure differs, I can tailor the lookup once you share an example of pylock.toml.

---

93-95: Avoid PKG_CONFIG_PATH over the entire filesystem.

Finding every pkgconfig dir across / is slow and non-deterministic. Set known paths explicitly.

-    export PKG_CONFIG_PATH=$(find / -type d -name "pkgconfig" 2>/dev/null | tr '\n' ':')
+    export PKG_CONFIG_PATH="/usr/lib64/pkgconfig:/usr/local/lib64/pkgconfig:/opt/OpenBLAS/lib/pkgconfig:/usr/lib/pkgconfig:/usr/local/lib/pkgconfig"

---

17-19: Ensure temp dirs are cleaned up on early failure.

With set -e, failures skip the rm -rf. Add traps in both builders.

     TEMP_BUILD_DIR=$(mktemp -d)
+    trap 'rm -rf "${TEMP_BUILD_DIR}"' EXIT
     cd ${TEMP_BUILD_DIR}
@@
-    rm -rf ${TEMP_BUILD_DIR}
+    rm -rf ${TEMP_BUILD_DIR}
+    trap - EXIT

Apply the same pattern in build_pyarrow().

Also applies to: 31-33, 39-41, 62-64

---

103-103: Install wheels strictly from local artifacts.

To prevent network resolution pulling in extras from indexes, install using only local wheels.

-    uv pip install ${WHEEL_DIR}/*.whl
+    uv pip install --no-index --find-links "${WHEEL_DIR}" ${WHEEL_DIR}/*.whl

---

20-21: Minor: use echo for banner lines (readability).

The “:” builtin discards output; echo makes intent clear in logs.

-    : ================== Installing Pillow ==================
+    echo "================== Installing Pillow =================="
@@
-    : ================= Fix Pillow Wheel ====================
+    echo "================= Fix Pillow Wheel ===================="

Also applies to: 25-26

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: grdryn
PR: opendatahub-io/notebooks#1396
File: jupyter/tensorflow/ubi9-python-3.12/Pipfile:13-14
Timestamp: 2025-07-16T00:17:10.313Z
Learning: When checking PyPI wheel availability for aarch64 architecture, the actual wheel filenames use "manylinux2014_aarch64" pattern, not "linux_aarch64". This caused incorrect analysis in PR #1396 where CodeRabbit falsely claimed CUDA companion packages lacked aarch64 wheels when searching with the wrong pattern. The correct approach is to search for "manylinux2014_aarch64" or use a more generic "aarch64" pattern when verifying wheel availability for ARM64 compatibility.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#1998
File: runtimes/pytorch/ubi9-python-3.11/Dockerfile.cuda:23-24
Timestamp: 2025-08-19T11:40:33.157Z
Learning: jiridanek corrected CodeRabbit's false assessment about uv pip install --build-constraints flag during PR #1998 review. User demonstrated that uv 0.8.12 uses the plural form --build-constraints (not --build-constraint as incorrectly suggested by CodeRabbit), verified through direct command line help output, showing the importance of accepting corrections when evidence contradicts initial analysis.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#968
File: runtimes/rocm-pytorch/ubi9-python-3.12/Dockerfile.rocm:79-88
Timestamp: 2025-08-06T15:19:32.488Z
Learning: jiridanek corrected CodeRabbit's false assessment about uv pip install --index-strategy=unsafe-best-match flag during PR #968 review. The flag controls index selection strategy for choosing between multiple package registries (like PyPI and supplementary registries), not hash verification behavior as incorrectly suggested by CodeRabbit.

Learnt from: jiridanek
PR: opendatahub-io/notebooks#968
File: runtimes/tensorflow/ubi9-python-3.12/Dockerfile.cuda:152-158
Timestamp: 2025-08-02T10:26:52.388Z
Learning: CodeRabbit made an incorrect assessment about uv pip install --strict flag support during PR #968 review, suggesting its removal when the flag is actually supported in both uv 0.8.0 and 0.8.4. jiridanek correctly demonstrated the flag's availability through command line verification, showing the importance of thorough verification and accepting corrections when evidence contradicts initial analysis.