NO-JIRA: manifests: update orders of Image Streams

[kramaranya]

Description

Updated image order numbers to start from 4, making room for the new universal training images (CUDA, ROCm, CPU) to appear at the top of the workbench dropdown.

How Has This Been Tested?

Self checklist (all need to be checked):

• Ensure that you have run make test (gmake on macOS) before asking for review
• Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Chores
  • Reorganized notebook image display ordering to improve user navigation and experience.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR updates the opendatahub.io/notebook-image-order annotation across 13 ImageStream manifest files and one configuration file. Each annotation value is changed to reflect a new prioritization scheme for notebook image display ordering, with no structural or functional modifications to any files.

Changes

Cohort / File(s)	Change Summary
Configuration ci/package_versions_selftestdata.py	Annotation opendatahub.io/notebook-image-order updated from "1" to "4"
Code Server ImageStream manifests/base/code-server-notebook-imagestream.yaml	Annotation opendatahub.io/notebook-image-order updated from "19" to "14"
Jupyter Minimal Variants ImageStream manifests/base/jupyter-minimal-gpu-notebook-imagestream.yaml, manifests/base/jupyter-minimal-notebook-imagestream.yaml	Annotation opendatahub.io/notebook-image-order updated; GPU variant: "3" → "5", minimal variant: "1" → "4"
Jupyter PyTorch Variants ImageStream manifests/base/jupyter-pytorch-llmcompressor-imagestream.yaml, manifests/base/jupyter-pytorch-notebook-imagestream.yaml	Annotation opendatahub.io/notebook-image-order updated; LLMCompressor: "10" → "9", PyTorch: "9" → "8"
Jupyter ROCm Variants ImageStream manifests/base/jupyter-rocm-minimal-notebook-imagestream.yaml, manifests/base/jupyter-rocm-pytorch-notebook-imagestream.yaml, manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml	Annotation opendatahub.io/notebook-image-order updated; minimal: "5" → "6", PyTorch: "12" → "10", TensorFlow: "16" → "12"
Jupyter Other Variants ImageStream manifests/base/jupyter-tensorflow-notebook-imagestream.yaml, manifests/base/jupyter-trustyai-notebook-imagestream.yaml	Annotation opendatahub.io/notebook-image-order updated; TensorFlow: "14" → "11", TrustAI: "17" → "13"
RStudio ImageStream manifests/base/rstudio-gpu-notebook-imagestream.yaml, manifests/base/rstudio-notebook-imagestream.yaml	Annotation opendatahub.io/notebook-image-order updated; GPU: "22" → "16", standard: "21" → "15"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify all 13 annotation value updates are correct and match intended reordering schema
• Confirm no unintended modifications beyond annotation value changes
• Check that all ImageStream files remain valid YAML with no structural alterations

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately reflects the main change: updating the image stream ordering annotations across multiple manifest files.
Description check	✅ Passed	The PR description explains the purpose (making room for new universal training images) and provides context about the dropdown ordering, but testing and merge criteria checkboxes remain unchecked.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a10d6b and 3be12ec.

📒 Files selected for processing (13)

• ci/package_versions_selftestdata.py (1 hunks)
• manifests/base/code-server-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-minimal-gpu-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-minimal-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-pytorch-llmcompressor-imagestream.yaml (1 hunks)
• manifests/base/jupyter-pytorch-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-rocm-minimal-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-rocm-pytorch-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-tensorflow-notebook-imagestream.yaml (1 hunks)
• manifests/base/jupyter-trustyai-notebook-imagestream.yaml (1 hunks)
• manifests/base/rstudio-gpu-notebook-imagestream.yaml (1 hunks)
• manifests/base/rstudio-notebook-imagestream.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: validation-of-sw-versions-in-imagestreams

🔇 Additional comments (14)

manifests/base/jupyter-rocm-pytorch-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct and properly formatted.

The order value "10" aligns with the PR intent to reserve positions 1–3 for universal training images. No other fields are affected.

manifests/base/code-server-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct and properly formatted.

The order value "14" reflects the new prioritization scheme. No other fields are affected.

manifests/base/jupyter-rocm-minimal-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct.

The order value "6" aligns with the reordering strategy. No other fields are affected.

manifests/base/jupyter-trustyai-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct.

The order value "13" reflects the prioritization adjustment. No structural changes.

manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct.

The order value "12" aligns with the new ordering scheme. No other fields are affected.

manifests/base/rstudio-gpu-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct.

The order value "16" reflects the new prioritization. No structural changes.

manifests/base/jupyter-tensorflow-notebook-imagestream.yaml (1)

11-11: LGTM — Annotation update is correct.

The order value "11" aligns with the reordering strategy. No other fields are affected.

manifests/base/jupyter-pytorch-llmcompressor-imagestream.yaml (2)

11-11: LGTM — Annotation update is correct.

The order value "9" reflects the new prioritization scheme. No other fields are affected.

---

1-60: Verify completeness of the PR changes across all ImageStream files.

The AI summary indicates this PR updates 13 ImageStream files and a configuration file (ci/package_versions_selftestdata.py), but only 8 manifest files are provided for review. The provided files show new order values of: 6, 9, 10, 11, 12, 13, 14, and 16.

Per the PR description, positions 1–3 should be reserved for future universal training images, but the AI summary references additional files with orders 4, 5, and 15, which are not shown here.

Please confirm:

1. All 13 ImageStream files have been updated in the PR
2. No duplicate order values exist across all ImageStream files
3. The test data file (ci/package_versions_selftestdata.py) has been updated consistently

manifests/base/rstudio-notebook-imagestream.yaml (1)

11-11: Annotation update looks correct.

The change from "21" to "15" appropriately adjusts the ordering within the new numbering scheme.

manifests/base/jupyter-minimal-notebook-imagestream.yaml (1)

11-11: Annotation update looks correct.

The change from "1" to "4" reserves positions 1-3 for new universal training images as described in the PR objectives. Note that this image is marked as the default (opendatahub.io/default-image: "true" on Line 31), and moving it from position 1 to position 4 appears intentional based on the PR description.

manifests/base/jupyter-pytorch-notebook-imagestream.yaml (1)

11-11: Annotation update looks correct.

The change from "9" to "8" appropriately adjusts the ordering within the new numbering scheme.

ci/package_versions_selftestdata.py (1)

12-12: Test data correctly updated.

The annotation update from "1" to "4" properly mirrors the change in manifests/base/jupyter-minimal-notebook-imagestream.yaml, ensuring test data remains consistent with the actual manifests.

manifests/base/jupyter-minimal-gpu-notebook-imagestream.yaml (1)

11-11: Annotation update looks correct.

The opendatahub.io/notebook-image-order annotation is a valid OpenDataHub metadata field that controls the ordering of notebook images in the UI. The change from "3" to "5" aligns with reserving lower positions for new universal training images. Verify that no duplicate order values exist across all ImageStream manifests by running:

fd -e yaml -e yml . manifests/ | xargs rg -oP 'opendatahub.io/notebook-image-order:\s*"\K\d+' | sort -n | uniq -d

If this command produces no output, all order values are unique.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jiridanek]

this is a testinput file, it does not get deployed to the cluster and should not participate in the imagestreams numbering

[jiridanek]

ah, I see we have two 4's now, so 4 is the new 1; I get it now, ok

[jiridanek]

/lgtm, but I'll leave merge to somebody else; keep in mind rhds/notebooks also needs update

we should think through if this will influence openshift AI upgrades in any ways; I think not

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 89f9356 and 2 for PR HEAD 3be12ec in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9ef3f1e and 1 for PR HEAD 3be12ec in total

[openshift-ci]

@kramaranya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	3be12ec	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[atheo89]

Hi @kramaranya thanks for opening this PR the changes looks good to me as well. Question-did you test this changes along with you manifests in ODH and see that final dispaly on the UI? Moreover, could you share a link with your ImageStreams that you will introduce?