chore(ci, build): add support for KONFLUX Dockerfile builds in Makefile and tests#2934
Closed
jiridanek wants to merge 580 commits intoopendatahub-io:mainfrom
Closed
Conversation
Sync rhds/main from odh-io/main
…s/main Update Konflux references
…3.12/Dockerfile.konflux.cpu` (#1653) As a result of RHAIENG-780, we found a remaining difference in the runtime datascience ubi9 Dockerfile(s). This is fixed by adding the change of ownership to the default user, as described in RHAIENG-287. Co-authored-by: vsok <vsok@redhat.com>
Sync rhds/main from odh-io/main
Fix conflict 3 0
… it available on runtime
Signed-off-by: Nishan Acharya <Nishan.Acharya@ibm.com>
Apply private indexes on minimal workbenches cuda and rocm
… and set it available on runtime" This reverts commit 1899c39.
RHAIENG-495: revert "Lock rocm and cuda minimal packages from internal aipcc index and set it available on runtime"
Retrigger for CodeFlareSDK update build on jupyter-cuda-tensorflow image
…nt for AIPCC way of setting permissions in rocm base (#1682)
…nance and flexibility
…n the corresponding cuda or rocm
…dependencies (opendatahub-io#2917) * chore(buildinputs): `go mod tidy`: update Go to 1.25 and bump module dependencies The Platform field moved from sourceresolver.Opt to sourceresolver.Opt.ImageOpt.Platform in buildkit v0.27.x. * This error occurs when upgrading OpenTelemetry SDK dependencies - internal packages have been reorganized in v1.40.0. Let me examine the Go module files to understand the situation. The issue is a version compatibility problem between OpenTelemetry packages. When `go get -u all` tries to upgrade `go.opentelemetry.io/otel/sdk` from v1.38.0 to v1.40.0, it creates an incompatibility with the contrib instrumentation packages (v0.63.0) that still reference internal packages that were reorganized in v1.40.0. The `go get -u all` command is not recommended because it can cause these kinds of version mismatches. Here are your options: **Option 1: Upgrade contrib packages together with SDK (recommended)** Run these commands to upgrade both the SDK and contrib packages to compatible versions: ``` cd scripts/buildinputs go get go.opentelemetry.io/otel@latest go get go.opentelemetry.io/otel/sdk@latest go get go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc@latest go get go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace@latest go get go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp@latest go mod tidy ``` **Option 2: Reset and let moby/buildkit determine compatible versions** Since these are indirect dependencies pulled in by `moby/buildkit`, you can let the buildkit dependency dictate the versions: ``` cd scripts/buildinputs git checkout go.mod go.sum go get github.com/moby/buildkit@latest go mod tidy ``` **Option 3: Upgrade specific packages instead of all** Avoid `go get -u all` and instead upgrade only what you need: ``` cd scripts/buildinputs go get github.com/moby/buildkit@latest go mod tidy ``` * update to new release https://github.com/openshift/check-payload/releases/tag/0.3.12 ``` git ls-remote --tags https://github.com/openshift/check-payload.git | grep -E '0\.3\.12|refs/tags/$' | head -20 92e2a43f840ef4aa471baa42e392d803f816aa58 refs/tags/0.3.12 go get github.com/openshift/check-payload@92e2a43f840ef4aa471baa42e392d803f816aa58 go mod tidy ```
…ex) 3.4-EA1 version, update feast back to 0.59 (opendatahub-io#2922) * update `INDEX_URL` and `CPU_INDEX_URL` to AIPCC 3.4-EA1 across all runtime and Jupyter build configurations * update URLs in `pylock.cuda.toml` to use `packages.redhat.com` endpoint instead of `console.redhat.com`.
…, and pnpm lockfile with latest dependency versions (opendatahub-io#2926)
…nd default test image (opendatahub-io#2926) - Introduced a reusable GitHub Action for Playwright tests to simplify workflow configurations. - Centralized DEFAULT_TEST_IMAGE in `playwright.config.ts` for easier maintenance. - Updated workflows to use the new action, removing duplicate logic, and enabling artifact uploads for CI.
…stopped including 1.x versions
…-io#2929) - Uncomment codeflare-sdk in jupyter/datascience and runtimes/datascience - Add Codeflare-SDK to jupyter-datascience-notebook imagestream manifest
…ture when we introduced base-images Co-authored-by: Cursor <cursoragent@cursor.com>
…file and tests - Introduced `KONFLUX` flag in Makefile for building images with `Dockerfile.konflux.*`. - Added `TestMakefile` class to verify `KONFLUX`-specific configurations. - Updated helper methods for handling new makefile logic and assertions. Co-authored-by: Cursor <cursoragent@cursor.com>
…bases in red-hat-data-services
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
github-actions
bot
added
the
review-requested
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile.konflux.*builds in Makefile and tests #2933Description
How Has This Been Tested?
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria: