-
Notifications
You must be signed in to change notification settings - Fork 129
RHAIENG-2846 [3/3]: Hermetic Dockerfile + build patches + Tekton for codeserver #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,13 @@ metadata: | |
| pipelinesascode.tekton.dev/cancel-in-progress: "false" | ||
| pipelinesascode.tekton.dev/max-keep-runs: "3" | ||
| build.appstudio.openshift.io/build-nudge-files: "manifests/base/params-latest.env" | ||
| pipelinesascode.tekton.dev/on-cel-expression: event == "push" && target_branch == "main" && !("manifests/base/params-latest.env".pathChanged()) && ( ".tekton/odh-workbench-codeserver-datascience-cpu-py312-ubi9-push.yaml".pathChanged() || "codeserver/ubi9-python-3.12/**".pathChanged() || "codeserver/ubi9-python-3.12/build-args/cpu.conf".pathChanged() ) | ||
| pipelinesascode.tekton.dev/on-cel-expression: | | ||
| event == "push" && target_branch == "main" && | ||
| !("manifests/base/params-latest.env".pathChanged()) && | ||
| ( | ||
| ".tekton/odh-workbench-codeserver-datascience-cpu-py312-ubi9-push.yaml".pathChanged() || | ||
| "codeserver/ubi9-python-3.12/**".pathChanged() | ||
| ) | ||
| creationTimestamp: | ||
| labels: | ||
| appstudio.openshift.io/application: opendatahub-release | ||
|
|
@@ -17,9 +23,13 @@ metadata: | |
| name: odh-workbench-codeserver-datascience-cpu-py312-ubi9-on-push | ||
| namespace: open-data-hub-tenant | ||
| spec: | ||
| timeouts: | ||
| pipeline: 6h | ||
| params: | ||
| - name: event-type | ||
| value: '{{event_type}}' | ||
| - name: enable-cache-proxy | ||
| value: "true" | ||
| - name: git-url | ||
| value: '{{source_url}}' | ||
| - name: revision | ||
|
|
@@ -30,6 +40,8 @@ spec: | |
| value: codeserver/ubi9-python-3.12/Dockerfile.cpu | ||
| - name: build-args-file | ||
| value: codeserver/ubi9-python-3.12/build-args/cpu.conf | ||
| - name: hermetic | ||
| value: "true" | ||
| - name: path-context | ||
| value: . | ||
| - name: additional-tags | ||
|
|
@@ -40,6 +52,124 @@ spec: | |
| value: | ||
| - linux-d160-m4xlarge/amd64 | ||
| - linux-d160-m4xlarge/arm64 | ||
| - linux/ppc64le | ||
| - name: prefetch-input | ||
| value: | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/odh | ||
| type: rpm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/odh | ||
| type: generic | ||
| - path: codeserver/ubi9-python-3.12 | ||
| type: pip | ||
| binary: | ||
| arch: "x86_64,aarch64,ppc64le" | ||
| requirements_files: ["requirements.cpu.txt"] | ||
|
Comment on lines
56
to
66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify hermetic parameter presence in both Tekton YAMLs
echo "=== Pull-request YAML ==="
rg -n 'hermetic' .tekton/odh-workbench-codeserver-datascience-cpu-py312-ubi9-pull-request.yaml || echo "NOT FOUND"
echo ""
echo "=== Push YAML ==="
rg -n 'hermetic' .tekton/odh-workbench-codeserver-datascience-cpu-py312-ubi9-push.yaml || echo "NOT FOUND"
echo ""
echo "=== Check for all push YAMLs with hermetic ==="
rg -l 'hermetic' .tekton/*push*.yaml 2>/dev/null || echo "No push YAMLs have hermetic"
echo ""
echo "=== Display relevant section of push YAML around lines 49-59 ==="
sed -n '45,65p' .tekton/odh-workbench-codeserver-datascience-cpu-py312-ubi9-push.yamlRepository: opendatahub-io/notebooks Length of output: 1112 Add missing The pull-request YAML includes 🐛 Proposed fix - name: build-args-file
value: codeserver/ubi9-python-3.12/build-args/cpu.conf
+ - name: hermetic
+ value: "true"
- name: prefetch-input
value:🤖 Prompt for AI Agents |
||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/.vscode/extensions/vscode-selfhost-import-aid | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/.vscode/extensions/vscode-selfhost-test-provider | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/build | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/build/npm/gyp | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/configuration-editing | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/css-language-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/css-language-features/server | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/debug-auto-launch | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/debug-server-ready | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/emmet | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/extension-editing | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/git | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/git-base | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/github | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/github-authentication | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/grunt | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/gulp | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/html-language-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/html-language-features/server | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/ipynb | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/jake | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/json-language-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/json-language-features/server | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/markdown-language-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/markdown-math | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/media-preview | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/merge-conflict | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/mermaid-chat-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/notebook-renderers | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/npm | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/php-language-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/references-view | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/simple-browser | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/tunnel-forwarding | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/typescript-language-features | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/vscode-api-tests | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/vscode-colorize-perf-tests | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/vscode-colorize-tests | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/extensions/vscode-test-resolver | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/remote | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/remote/web | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/test/automation | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/test/integration/browser | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/test/mcp | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/test/monaco | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode/test/smoke | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server/test/e2e/extensions/test-extension | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/code-server | ||
| type: npm | ||
| # patches/ | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/patches/code-server-v4.106.3/lib/vscode | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/patches/code-server-v4.106.3/test | ||
| type: npm | ||
| - path: codeserver/ubi9-python-3.12/prefetch-input/patches/code-server-v4.106.3/lib/vscode/extensions/microsoft-authentication | ||
| type: npm | ||
|
|
||
| pipelineRef: | ||
| name: multiarch-combined-pipeline | ||
| taskRunTemplate: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.