RHOAIENG-20088: chore(tests/containers) + GHA CI update: check images size change #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jstourac
changed the title
jstourac
force-pushed
the
testImgSize
branch
from
50c63a4 to
7319df6
Compare
jstourac
force-pushed
the
testImgSize
branch
from
7319df6 to
d6331d8
Compare
jstourac
force-pushed
the
testImgSize
branch
from
d6331d8 to
fb7599a
Compare
jstourac
commented
Feb 18, 2025
jstourac
force-pushed
the
testImgSize
branch
from
fb7599a to
8201d5c
Compare
jstourac
force-pushed
the
testImgSize
branch
from
8201d5c to
84b0b4e
Compare
|
Didn't expect that many CI failures with this run - looks like the image sizes differ here against what I checked it locally. I'll check what is the rootcause tomorrow. Also, I tried to raise a testing PR with the updated pipfiles to force the images being build jstourac#7 . Let's see. |
jstourac
force-pushed
the
testImgSize
branch
from
d39b6ba to
bc5a783
Compare
Adds a new test to our pytest set to check the given image size compared to the expected value. In this test we are checking the uncompressed image size by summing up all the layeres of the image. This image is usually downloaded on the machine where this is being run already. https://issues.redhat.com/browse/RHOAIENG-20088
jiridanek
added a commit
to jiridanek/notebooks
that referenced
this pull request
Jun 18, 2025
|
@jstourac is that PR still valid? |
|
Caution There are some errors in your PipelineRun template.
List of images referenced from the Python code generation scripts for Tekton pipelines.The structure of this file must be compatible withhttps://docs.renovatebot.com/modules/manager/tekton/Specifically, see
|
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhances our existing ci scripts for the params.env and existing
runtimes definitions with the actual image size check - we have preset
expected size for each of the image and we check that this size isn't
changed too much.
With this implementation we are checking the compressed image size to
avoid the image download.
Adds a new test to our pytest set to check the given image size compared
to the expected value. In this test we are checking the uncompressed
image size by summing up all the layeres of the image. This image is
usually downloaded on the machine where this is being run already.
https://issues.redhat.com/browse/RHOAIENG-20088
How Has This Been Tested?
Local execution of the:
and for the Pytest:
for each image separately (e.g. runtimes):
We shall check all the existing images before merging this, though.
Merge criteria: