Skip to content

Commit 48d734c

Browse files
committed
Updating acc to CodeRabbit suggestions
1 parent 23ec8d0 commit 48d734c

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

modules/updating-lmeval-job-configuration-using-the-cli.adoc

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ ifdef::context[:parent-context: {context}]
66
= Updating LMEval Job configuration using the CLI
77

88
[role='_abstract']
9-
Follow these steps to enable online access (`allowOnline`) and remote code execution (`allowCodeExecution`) modes using the CLI for LMEval Jobs.
9+
Follow these steps to enable online access (`allowOnline`) or remote code execution (`allowCodeExecution`) or both modes using the CLI for LMEval Jobs.
1010

1111
[IMPORTANT]
1212
====
13-
Enabling online access and code execution involves a security risk. Only use these configurations if you trust the source(s).
13+
Enabling online access or code execution involves a security risk. Only use these configurations if you trust the source(s).
1414
====
1515

1616
.Prerequisites
@@ -86,11 +86,13 @@ oc rollout restart deployment trustyai-service-operator-controller-manager -n re
8686
----
8787
oc rollout restart deployment trustyai-service-operator-controller-manager -n redhat-ods-applications
8888
----
89-
. Enable online access and/or code execution on the specific `LMEvalJob`:
89+
. Enable online access or code execution or both on specific `LMEvalJob` resources:
9090
+
9191
[source,sh]
9292
----
93-
# Patch an existing job (example name: example-lmeval)
94-
oc patch lmevaljob example-lmeval -n <user-or-target-namespace> \
93+
oc patch lmevaljobs example-lmeval -n <user-or-target-namespace> \
9594
--type merge -p '{"spec":{"allowOnline":true,"allowCodeExecution":true}}'
95+
96+
oc get lmevaljobs example-lmeval -n <user-or-target-namespace> \
97+
-o jsonpath='{.spec.allowOnline}{"\n"}{.spec.allowCodeExecution}{"\n"}'
9698
----

modules/updating-lmeval-job-configuration-using-the-console.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Follow these steps to enable online access (`allowOnline`) and remote code execu
99

1010
[IMPORTANT]
1111
====
12-
Enabling online access and code execution involves a security risk. Only use these configurations if you trust the source(s).
12+
Enabling online access or code execution involves a security risk. Only use these configurations if you trust the source(s).
1313
====
1414

1515
.Prerequisites
@@ -25,16 +25,16 @@ Enabling online access and code execution involves a security risk. Only use the
2525

2626
. Under *Annotations*, add:
2727
+
28-
[source, sh]
28+
[source, yaml]
2929
----
30-
opendatahub.io/managed: false
30+
opendatahub.io/managed: "false"
3131
----
3232
. Under *Data*, add or update:
3333
+
34-
[source, sh]
34+
[source, yaml]
3535
----
36-
lmes-allow-online: true
37-
lmes-allow-code-execution: true
36+
lmes-allow-online: "true"
37+
lmes-allow-code-execution: "true"
3838
----
3939
. Save the ConfigMap.
4040

0 commit comments

Comments
 (0)