-
Notifications
You must be signed in to change notification settings - Fork 28
RHOAIENG-28660: Updates to T&V runtimes for IBM Z Triton #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eturner24
wants to merge
2
commits into
opendatahub-io:main
Choose a base branch
from
eturner24:RHOAIENG-28660-ibm-z-triton
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,16 +4,19 @@ | |
|
||
= Adding a tested and verified model-serving runtime for the single-model serving platform | ||
|
||
In addition to preinstalled and custom model-serving runtimes, you can also use {org-name} tested and verified model-serving runtimes such as the *NVIDIA Triton Inference Server* to support your needs. For more information about {org-name} tested and verified runtimes, see link:https://access.redhat.com/articles/7089743[Tested and verified runtimes for {productname-long}^]. | ||
In addition to preinstalled and custom model-serving runtimes, you can also use {org-name} tested and verified model-serving runtimes to support your needs. For more information about {org-name} tested and verified runtimes, see link:https://access.redhat.com/articles/7089743[Tested and verified runtimes for {productname-long}^]. | ||
|
||
You can use the {productname-long} dashboard to add and enable the *NVIDIA Triton Inference Server* or the *Seldon MLServer* runtime for the single-model serving platform. You can then choose the runtime when you deploy a model on the single-model serving platform. | ||
You can use the {productname-long} dashboard to add and enable tested and verified runtimes for the single-model serving platform. You can then choose the runtime when you deploy a model on the single-model serving platform. | ||
|
||
[role='_abstract'] | ||
|
||
.Prerequisites | ||
|
||
* You have logged in to {productname-short} as a user with {productname-short} administrator privileges. | ||
* If you are deploying the IBM Z Accelerated for NVIDIA Triton Inference Server runtime, you have access to IBM cloud container registry to pull the container image. For more information about obtaining credentials to the IBM cloud container registry, see link:https://github.com/IBM/ibmz-accelerated-for-nvidia-triton-inference-server?tab=readme-ov-file#container[Inference Server container image^]. | ||
|
||
.Procedure | ||
|
||
. From the {productname-short} dashboard, click *Settings* -> *Serving runtimes*. | ||
+ | ||
The *Serving runtimes* page opens and shows the model-serving runtimes that are already installed and enabled. | ||
|
@@ -26,8 +29,133 @@ The *Serving runtimes* page opens and shows the model-serving runtimes that are | |
|
||
. Click *Start from scratch*. | ||
|
||
. Follow these steps to add the *NVIDIA Triton Inference Server* runtime: | ||
. Follow these steps to add the *IBM Z Accelerated for NVIDIA Triton Inference Server* runtime: | ||
.. If you selected the *REST* API protocol, enter or paste the following YAML code directly in the embedded editor. | ||
+ | ||
[source] | ||
---- | ||
apiVersion: serving.kserve.io/v1alpha1 | ||
kind: ServingRuntime | ||
metadata: | ||
name: ibmz-triton-rest | ||
labels: | ||
opendatahub.io/dashboard: "true" | ||
spec: | ||
annotations: | ||
prometheus.kserve.io/path: /metrics | ||
prometheus.kserve.io/port: "8002" | ||
containers: | ||
- name: kserve-container | ||
command: | ||
- /bin/sh | ||
- -c | ||
args: | ||
- /opt/tritonserver/bin/tritonserver --model-repository=/mnt/models --http-port=8000 --grpc-port=8001 --metrics-port=8002 | ||
image: icr.io/ibmz/ibmz-accelerated-for-nvidia-triton-inference-server:xxx | ||
securityContext: | ||
allowPrivilegeEscalation: false | ||
capabilities: | ||
drop: | ||
- ALL | ||
runAsNonRoot: true | ||
seccompProfile: | ||
type: RuntimeDefault | ||
resources: | ||
limits: | ||
cpu: "2" | ||
memory: 4Gi | ||
requests: | ||
cpu: "5" | ||
memory: 4Gi | ||
ports: | ||
- containerPort: 8000 | ||
protocol: TCP | ||
protocolVersions: | ||
- v2 | ||
- grpc-v2 | ||
supportedModelFormats: | ||
- name: python | ||
version: "1" | ||
autoSelect: true | ||
- name: onnx-mlir | ||
version: "1" | ||
autoSelect: true | ||
- name: snapml | ||
version: "1" | ||
autoSelect: true | ||
- name: pytorch | ||
version: "1" | ||
autoSelect: true | ||
---- | ||
|
||
.. If you selected the *gRPC* API protocol, enter or paste the following YAML code directly in the embedded editor. | ||
+ | ||
[source] | ||
---- | ||
apiVersion: serving.kserve.io/v1alpha1 | ||
kind: ServingRuntime | ||
metadata: | ||
name: ibmz-triton-grpc | ||
labels: | ||
opendatahub.io/dashboard: "true" | ||
spec: | ||
annotations: | ||
prometheus.kserve.io/path: /metrics | ||
prometheus.kserve.io/port: "8002" | ||
containers: | ||
- name: kserve-container | ||
command: | ||
- /bin/sh | ||
- -c | ||
args: | ||
- /opt/tritonserver/bin/tritonserver --model-repository=/mnt/models --grpc-port=8001 --http-port=8000 --metrics-port=8002 | ||
image: icr.io/ibmz/ibmz-accelerated-for-nvidia-triton-inference-server:xxx | ||
securityContext: | ||
allowPrivilegeEscalation: false | ||
capabilities: | ||
drop: | ||
- ALL | ||
runAsNonRoot: true | ||
seccompProfile: | ||
type: RuntimeDefault | ||
resources: | ||
limits: | ||
cpu: "2" | ||
memory: 4Gi | ||
requests: | ||
cpu: "5" | ||
memory: 4Gi | ||
ports: | ||
- containerPort: 8001 | ||
name: grpc | ||
protocol: TCP | ||
volumeMounts: | ||
- mountPath: /dev/shm | ||
name: shm | ||
protocolVersions: | ||
- v2 | ||
- grpc-v2 | ||
supportedModelFormats: | ||
- name: python | ||
version: "1" | ||
autoSelect: true | ||
- name: onnx-mlir | ||
version: "1" | ||
autoSelect: true | ||
- name: snapml | ||
version: "1" | ||
autoSelect: true | ||
- name: pytorch | ||
version: "1" | ||
autoSelect: true | ||
volumes: | ||
- emptyDir: null | ||
medium: Memory | ||
sizeLimit: 2Gi | ||
name: shm | ||
Comment on lines
+152
to
+155
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Volume definition malformed – Current structure: - emptyDir: null
medium: Memory
sizeLimit: 2Gi
name: shm Valid structure: - emptyDir: null
- medium: Memory
- sizeLimit: 2Gi
+emptyDir:
+ medium: Memory
+ sizeLimit: 2Gi Without this fix the manifest fails to parse. 🤖 Prompt for AI Agents
|
||
---- | ||
|
||
. Follow these steps to add the *NVIDIA Triton Inference Server* runtime: | ||
.. If you selected the *REST* API protocol, enter or paste the following YAML code directly in the embedded editor. | ||
+ | ||
[source] | ||
|
@@ -162,6 +290,7 @@ volumes: | |
sizeLimit: 2Gi | ||
name: shm | ||
---- | ||
|
||
. Follow these steps to add the *Seldon MLServer* runtime: | ||
.. If you selected the *REST* API protocol, enter or paste the following YAML code directly in the embedded editor. | ||
+ | ||
|
@@ -360,6 +489,7 @@ The *Serving runtimes* page opens and shows the updated list of runtimes that ar | |
. Optional: To edit the runtime, click the action menu (⋮) and select *Edit*. | ||
|
||
.Verification | ||
|
||
* The model-serving runtime that you added is shown in an enabled state on the *Serving runtimes* page. | ||
|
||
[role='_additional-resources'] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requests.cpu
greater thanlimits.cpu
– scheduling will fail.Kubernetes requires
requests <= limits
.Swap the values (or raise limits) to avoid
spec.containers[].resources.limits.cpu: Invalid value
.Apply to both REST (lines 65-70) and gRPC (124-129) variants.
Also applies to: 124-129
🤖 Prompt for AI Agents