Skip to content

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Mar 15, 2025

  • we should consider when user enable devFlags some parameters set need to be kept e.g namespaces past to params.env
  • deprecated som devflags(), move into initialize() and set customized value after devFlag logic is called
  • use GetDevFlags() instead

follow up convesation from #1744 (comment)

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- we should consider when user enable devFlags some parameters set need to be kept
  e.g namespaces past to params.env

Signed-off-by: Wen Zhou <[email protected]>
Copy link

openshift-ci bot commented Mar 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign carlkyrillos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 72 lines in your changes missing coverage. Please review.

Project coverage is 23.99%. Comparing base (015c546) to head (3149477).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/modelcontroller/modelcontroller_actions.go 0.00% 24 Missing ⚠️
...mponents/codeflare/codeflare_controller_actions.go 0.00% 21 Missing ⚠️
...ntrollers/components/ray/ray_controller_actions.go 0.00% 19 Missing ⚠️
...mponents/dashboard/dashboard_controller_actions.go 0.00% 1 Missing ⚠️
...pelines/datasciencepipelines_controller_actions.go 0.00% 1 Missing ⚠️
.../feastoperator/feastoperator_controller_actions.go 0.00% 1 Missing ⚠️
...llers/components/kueue/kueue_controller_actions.go 0.00% 1 Missing ⚠️
...ents/modelcontroller/modelcontroller_controller.go 0.00% 1 Missing ⚠️
...ingoperator/trainingoperator_controller_actions.go 0.00% 1 Missing ⚠️
...components/trustyai/trustyai_controller_actions.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
+ Coverage   23.95%   23.99%   +0.03%     
==========================================
  Files         171      172       +1     
  Lines       11662    11691      +29     
==========================================
+ Hits         2794     2805      +11     
- Misses       8590     8606      +16     
- Partials      278      280       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valdar
Copy link
Member

valdar commented May 8, 2025

are there any tests already in place for devFlags handling logic?

@zdtsw
Copy link
Member Author

zdtsw commented May 8, 2025

are there any tests already in place for devFlags handling logic?

looks like we only have the basic Get/Set tests on it, no functional or e2e for devFlags

@valdar
Copy link
Member

valdar commented May 8, 2025

looks like we only have the basic Get/Set tests on it, no functional or e2e for devFlags

Captured that in this jira https://issues.redhat.com/browse/RHOAIENG-25127

Copy link

openshift-ci bot commented Aug 11, 2025

@zdtsw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e 3149477 link true /test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants