-
Notifications
You must be signed in to change notification settings - Fork 190
chore: update devFlags logic #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- we should consider when user enable devFlags some parameters set need to be kept e.g namespaces past to params.env Signed-off-by: Wen Zhou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
+ Coverage 23.95% 23.99% +0.03%
==========================================
Files 171 172 +1
Lines 11662 11691 +29
==========================================
+ Hits 2794 2805 +11
- Misses 8590 8606 +16
- Partials 278 280 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
are there any tests already in place for |
looks like we only have the basic Get/Set tests on it, no functional or e2e for devFlags |
Captured that in this jira https://issues.redhat.com/browse/RHOAIENG-25127 |
@zdtsw: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
follow up convesation from #1744 (comment)
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria