update: changes related to old upgrade logic

[zdtsw]

• cleanup below upgrade temp workaround:

1. https://issues.redhat.com/browse/RHOAIENG-4764
2. https://issues.redhat.com/browse/RHOAIENG-13604
3. https://issues.redhat.com/browse/RHOAIENG-15328
4. https://issues.redhat.com/browse/RHOAIENG-443
5. https://issues.redhat.com/browse/RHOAIENG-165

• change logic for checks on Self and Managed to non-ODH: do not merge till update: remove Unknown constant from platform detection logic #1761 is in
• move logf only when in upgrade case
• move interal function into support file, to keep upgrade.go short

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[codecov]

Codecov Report

Attention: Patch coverage is 22.66667% with 58 lines in your changes missing coverage. Please review.

Project coverage is 24.62%. Comparing base (5e0eb72) to head (2c71188).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/upgrade/upgrade_support.go	18.64%	47 Missing and 1 partial ⚠️
pkg/upgrade/upgrade.go	42.85%	8 Missing ⚠️
...ntroller/components/dashboard/dashboard_support.go	0.00%	1 Missing ⚠️
...ents/workbenches/workbenches_controller_actions.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
+ Coverage   24.19%   24.62%   +0.43%     
==========================================
  Files         170      171       +1     
  Lines       11796    11547     -249     
==========================================
- Hits         2854     2844      -10     
+ Misses       8671     8432     -239     
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/14078956671

[zdtsw]

FYI @TomerFi

[andrewballantyne]

Looks okay to me -- seems like a general cleanup ticket. Not sure this even impacts Dashboard 🤔 I'll give it an approval on my side -- != to ODH seems find if we grow to have other offerings in the RHOAI space...

[zdtsw]

Looks okay to me -- seems like a general cleanup ticket. Not sure this even impacts Dashboard 🤔 I'll give it an approval on my side -- != to ODH seems find if we grow to have other offerings in the RHOAI space...

add all "impacted" stackholders here as reviewers, just to see if upgrade from existing EUS 2.16 / to be-stable 2.19 / fast 2.18 could be an issue. 😆 (hope not)

[dhirajsb]

I'm not sure whether my review is needed. Does it affect MR upgrades somehow?

[dhirajsb]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne, dhirajsb
Once this PR has been reviewed and has the lgtm label, please assign lburgazzoli for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@zdtsw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-bundle-opendatahub-operator-bundle	2c71188	link	true	/test ci-bundle-opendatahub-operator-bundle
ci/prow/opendatahub-operator-e2e	2c71188	link	true	/test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.