-
Notifications
You must be signed in to change notification settings - Fork 192
[RHOAIENG-28366] Add SCC access for llm-d #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The DP<>EP deployment requires running with privileged, hostIPC, hostPID, so Kserve controller will bundle an SCC as part of the manifests. Signed-off-by: Pierangelo Di Pilato <[email protected]>
Skipping CI for Draft Pull Request. |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
=======================================
Coverage 41.40% 41.40%
=======================================
Files 141 141
Lines 11012 11012
=======================================
Hits 4559 4559
Misses 6070 6070
Partials 383 383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -1017,6 +1017,21 @@ rules: | |||
- securitycontextconstraints | |||
verbs: | |||
- '*' | |||
- apiGroups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should already have
- apiGroups:
- security.openshift.io
resources:
- securitycontextconstraints
verbs:
- '*'
The DP<>EP deployment requires running with privileged, hostIPC, hostPID, so Kserve controller will bundle an SCC as part of the manifests.
Related to opendatahub-io/kserve#802