chore(deps): bumps kustomize libraries#2259
Conversation
Without updating kyaml and kustomize api it's not possible to use patches containing several targets. The issue is reported as component's condition: ``` trouble configuring builtin PatchTransformer with config: ` │ path: remove-cert-manager.yaml │ `: unable to parse SM or JSON patch from [$patch: delete │ apiVersion: cert-manager.io/v1 │ kind: Issuer │ metadata: │ name: selfsigned-issuer │ namespace: kserve │ --- │ $patch: delete ``` Related issue: kubernetes-sigs/kustomize#5194 Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho, spolti, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@zdtsw any idea what's causing this? |
|
/retest |
|
/test opendatahub-operator-e2e |
|
/retest it keeps failing for the very same quota reason... |
|
/test opendatahub-operator-e2e |
|
some intersting error 👍 {"level":"error","ts":"2025-08-07T07:01:47Z","msg":"Reconciler |
Oh finally valuable error! I was afraid that due to bugs in kustomize we might have been using it wrong in a few places undetected. Hopefully fixed with opendatahub-io/modelmesh-serving#365 |
|
@spolti i am gonna put this in |
|
/retest |
Failing test was holding it back but ok :) |
|
modelmesh-serving is merged. |
|
/retest |
1 similar comment
|
/retest |
|
/retest We keep trying. Flaky tests :( |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=======================================
Coverage 42.14% 42.14%
=======================================
Files 144 144
Lines 11325 11325
=======================================
Hits 4773 4773
Misses 6151 6151
Partials 401 401 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cherry-pick rhoai |
|
@zdtsw: new pull request created: #2339 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Without updating kyaml and kustomize api it's not possible to use patches containing several targets. The issue is reported as component's condition: ``` trouble configuring builtin PatchTransformer with config: ` │ path: remove-cert-manager.yaml │ `: unable to parse SM or JSON patch from [$patch: delete │ apiVersion: cert-manager.io/v1 │ kind: Issuer │ metadata: │ name: selfsigned-issuer │ namespace: kserve │ --- │ $patch: delete ``` Related issue: kubernetes-sigs/kustomize#5194 Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit e5e63a0)
5 participants
Description
Without updating kyaml and kustomize api it's not possible to use patches containing several targets.
The issue is reported as component's condition:
Related issue: kubernetes-sigs/kustomize#5194
How Has This Been Tested?
Merge criteria
Summary by CodeRabbit