Skip to content

[rhoai] chore(deps): bumps kustomize libraries#2339

Merged
carlkyrillos merged 1 commit intoopendatahub-io:rhoaifrom
openshift-cherrypick-robot:cherry-pick-2259-to-rhoai
Aug 21, 2025
Merged

[rhoai] chore(deps): bumps kustomize libraries#2339
carlkyrillos merged 1 commit intoopendatahub-io:rhoaifrom
openshift-cherrypick-robot:cherry-pick-2259-to-rhoai

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #2259

/assign zdtsw

Without updating kyaml and kustomize api it's not possible to use
patches containing several targets.

The issue is reported as component's condition:

```
trouble configuring builtin PatchTransformer with config: `                                                                                                                           │
path: remove-cert-manager.yaml                                                                                                                                                        │
`: unable to parse SM or JSON patch from [$patch: delete                                                                                                                              │
apiVersion: cert-manager.io/v1                                                                                                                                                        │
kind: Issuer                                                                                                                                                                          │
metadata:                                                                                                                                                                             │
  name: selfsigned-issuer                                                                                                                                                             │
  namespace: kserve                                                                                                                                                                   │
---                                                                                                                                                                                   │
$patch: delete
```

Related issue: kubernetes-sigs/kustomize#5194

Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot requested review from AjayJagan and lphiri August 20, 2025 17:59
@openshift-ci openshift-ci bot added the lgtm label Aug 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member

zdtsw commented Aug 20, 2025

@grdryn / @ugiordan a very bad example of using cherry-pick bot
see failed linter check^

@ugiordan
Copy link
Member

@grdryn/ @ugiordan a very bad example of using cherry-pick bot see failed linter check^

Strange, why isn’t the linter also failing on the main PR?

@zdtsw
Copy link
Member

zdtsw commented Aug 21, 2025

@grdryn/ @ugiordan a very bad example of using cherry-pick bot see failed linter check^

Strange, why isn’t the linter also failing on the main PR?

i think this PR was before we uplift to 1.24 and the code was correct.
but somehow this PR source was used for linter, not the result after merge.
and we do not have permission to add commit on the source branch since it is from a bot
the only way to get this out is 1) we know the linter will work after merge 2) drop this PR and create one manually

@zdtsw
Copy link
Member

zdtsw commented Aug 21, 2025

#2342 to fix lint error

@zdtsw
Copy link
Member

zdtsw commented Aug 21, 2025

lint error is something unrelated to this PR, we will take another look later to improve the process.
as for the e2e job, we are waiting for fix in modelmesh first then we rebuild the image and run e2e again.

@zdtsw zdtsw requested review from carlkyrillos and spolti August 21, 2025 16:49
@carlkyrillos
Copy link
Member

/test images

@carlkyrillos
Copy link
Member

/test opendatahub-operator-e2e

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.10%. Comparing base (f52934c) to head (7e2823c).
⚠️ Report is 3 commits behind head on rhoai.

Additional details and impacted files
@@           Coverage Diff           @@
##            rhoai    #2339   +/-   ##
=======================================
  Coverage   40.10%   40.10%           
=======================================
  Files         151      151           
  Lines       12158    12158           
=======================================
  Hits         4876     4876           
  Misses       6873     6873           
  Partials      409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlkyrillos carlkyrillos merged commit ab30aaa into opendatahub-io:rhoai Aug 21, 2025
10 of 13 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in ODH Platform Planning Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants