Skip to content

chore: add maas-controller-image to image map#3270

Open
ishitasequeira wants to merge 1 commit intoopendatahub-io:mainfrom
ishitasequeira:fix/add-maas-controller-image-map
Open

chore: add maas-controller-image to image map#3270
ishitasequeira wants to merge 1 commit intoopendatahub-io:mainfrom
ishitasequeira:fix/add-maas-controller-image-map

Conversation

@ishitasequeira
Copy link
Contributor

@ishitasequeira ishitasequeira commented Mar 13, 2026

Description

Add maas-controller image support for ModelsAsService

Adds RELATED_IMAGE_ODH_MAAS_CONTROLLER_IMAGE to operands-map.yaml and the maas-controller-image mapping in modelsasservice_support.go so the operator can deploy the maas-controller with the correct image.

Depends on: opendatahub-io/models-as-a-service#497

Build Config Change: opendatahub-io/ODH-Build-Config#579

How Has This Been Tested?

Validated Manually

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has run the integration test pipeline and verified that it passed successfully

E2E test suite update requirement

When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.

To opt-out of this requirement:

  1. Please inspect the opt-out guidelines, to determine if the nature of the PR changes allows for skipping this requirement
  2. If opt-out is applicable, provide justification in the dedicated E2E update requirement opt-out justification section below
  3. Check the checkbox below:
  • Skip requirement to update E2E test suite for this PR
  1. Submit/save these changes to the PR description. This will automatically trigger the check.

E2E update requirement opt-out justification

I think this would fall under dependency version update

Summary by CodeRabbit

  • Chores
    • Extended manifest substitution support for MaaS model service by adding image parameter mapping for the controller component, enabling proper image resolution during model service deployments.

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zdtsw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: abf00d44-007c-4878-85fc-ee8f26c07f36

📥 Commits

Reviewing files that changed from the base of the PR and between a746697 and e66c621.

📒 Files selected for processing (1)
  • internal/controller/components/modelsasservice/modelsasservice_support.go

📝 Walkthrough

Walkthrough

This change adds a single image parameter mapping entry to the MaaS model service support configuration. Specifically, it maps the "maas-controller-image" key to the RELATED_IMAGE_ODH_MAAS_CONTROLLER_IMAGE environment variable within the imagesMap structure. The modification extends the manifest substitution configuration to include the MaaS controller image without altering control flow or introducing new logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: add maas-controller-image to image map' directly and specifically describes the main change: adding a new image parameter mapping entry to the MaaS model service support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

@ishitasequeira
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

@ishitasequeira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e e66c621 link true /test opendatahub-operator-e2e
ci/prow/opendatahub-operator-rhoai-e2e e66c621 link true /test opendatahub-operator-rhoai-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant