chore: add maas-controller-image to image map#3270
chore: add maas-controller-image to image map#3270ishitasequeira wants to merge 1 commit intoopendatahub-io:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds a single image parameter mapping entry to the MaaS model service support configuration. Specifically, it maps the "maas-controller-image" key to the RELATED_IMAGE_ODH_MAAS_CONTROLLER_IMAGE environment variable within the imagesMap structure. The modification extends the manifest substitution configuration to include the MaaS controller image without altering control flow or introducing new logic. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
|
/retest |
|
@ishitasequeira: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Add maas-controller image support for ModelsAsService
Adds RELATED_IMAGE_ODH_MAAS_CONTROLLER_IMAGE to operands-map.yaml and the maas-controller-image mapping in modelsasservice_support.go so the operator can deploy the maas-controller with the correct image.
Depends on: opendatahub-io/models-as-a-service#497
Build Config Change: opendatahub-io/ODH-Build-Config#579
How Has This Been Tested?
Validated Manually
Screenshot or short clip
Merge criteria
E2E test suite update requirement
When bringing new changes to the operator code, such changes are by default required to be accompanied by extending and/or updating the E2E test suite accordingly.
To opt-out of this requirement:
E2E update requirement opt-out justificationsection belowE2E update requirement opt-out justification
I think this would fall under dependency version update
Summary by CodeRabbit