Skip to content

[odh-3.4.0-ea.2] override vllm gaudi imageparmMap#3304

Open
openshift-cherrypick-robot wants to merge 2 commits intoopendatahub-io:odh-3.4.0-ea.2from
openshift-cherrypick-robot:cherry-pick-3269-to-odh-3.4.0-ea.2
Open

[odh-3.4.0-ea.2] override vllm gaudi imageparmMap#3304
openshift-cherrypick-robot wants to merge 2 commits intoopendatahub-io:odh-3.4.0-ea.2from
openshift-cherrypick-robot:cherry-pick-3269-to-odh-3.4.0-ea.2

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #3269

/assign Jooho

Signed-off-by: Edward Arthur Quarm Jnr <equarmjn@redhat.com>
Signed-off-by: Edward Arthur Quarm Jnr <equarmjn@redhat.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • master
  • incubation
  • rhoai

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0f237273-e852-4089-befc-5d93c20d45e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold until either the RELATED_IMAGE_RHAII_VLLM_GAUDI_IMAGE is listed in https://github.com/red-hat-data-services/RHOAI-Build-Config/blob/rhoai-3.4-ea.2/bundle/additional-images-patch.yaml or the DevOps team confirm on this PR that it will be for EA2, and that it's okay for this PR to be merged beforehand.

@openshift-ci
Copy link

openshift-ci bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.80%. Comparing base (7563ddb) to head (f7d0ef1).
⚠️ Report is 21 commits behind head on odh-3.4.0-ea.2.

Additional details and impacted files
@@                Coverage Diff                 @@
##           odh-3.4.0-ea.2    #3304      +/-   ##
==================================================
+ Coverage           50.67%   50.80%   +0.12%     
==================================================
  Files                 195      196       +1     
  Lines               13996    14175     +179     
==================================================
+ Hits                 7093     7202     +109     
- Misses               6167     6238      +71     
+ Partials              736      735       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants