Skip to content

Comments

Remove old Trainer operator image build#65

Merged
sutaakar merged 1 commit intoopendatahub-io:mainfrom
sutaakar:image-build
Dec 12, 2025
Merged

Remove old Trainer operator image build#65
sutaakar merged 1 commit intoopendatahub-io:mainfrom
sutaakar:image-build

Conversation

@sutaakar
Copy link
Collaborator

@sutaakar sutaakar commented Dec 12, 2025

Build it replaced by Konflux.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Summary by CodeRabbit

  • Chores
    • Removed the operator image build and publish workflow.
    • Removed multi-arch build configuration for the controller manager.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Walkthrough

Removal of build and deployment infrastructure files: the GitHub Actions workflow for building and publishing ODH operator images (multi-stage pipeline with Docker/Buildah, registry login, and image validation) and the multi-arch Dockerfile for the trainer-controller-manager.

Changes

Cohort / File(s) Summary
Build and Deployment Infrastructure Removal
.github/workflows/odh-build-and-publish-operator-image.yaml, cmd/trainer-controller-manager/Dockerfile.multiarch
Deleted GitHub Actions workflow containing multi-stage CI pipeline for building and publishing operator images to Quay.io with multi-arch support (linux/amd64, linux/arm64), including environment setup, Go toolchain, Docker metadata generation, Buildah image build, validation steps, and registry push logic. Deleted Alpine/ubi-based multi-arch Dockerfile with ARG TARGETARCH, WORKDIR, COPY, USER, and ENTRYPOINT instructions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the removal is intentional and understand the replacement build/deployment strategy
  • Confirm no active dependencies on these workflows or Dockerfile from other CI/CD configurations

Poem

🐰 The workflows and Dockerfiles bid adieu,
Build scripts simplified, old cleaned for new,
Multi-arch dreams archived with care,
Streamlined pipelines fill the air!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change in the PR, which removes the entire ODH operator image build workflow and multi-arch Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fea7ab and e8dc0ac.

📒 Files selected for processing (2)
  • .github/workflows/odh-build-and-publish-operator-image.yaml (0 hunks)
  • cmd/trainer-controller-manager/Dockerfile.multiarch (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/odh-build-and-publish-operator-image.yaml
  • cmd/trainer-controller-manager/Dockerfile.multiarch
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: pre-commit
  • GitHub Check: Generate
  • GitHub Check: Test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20169830104

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.654%

Totals Coverage Status
Change from base Build 20070751636: 0.0%
Covered Lines: 1564
Relevant Lines: 2915

💛 - Coveralls

@sutaakar sutaakar merged commit e99c261 into opendatahub-io:main Dec 12, 2025
8 checks passed
@sutaakar sutaakar deleted the image-build branch December 12, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants