unpin vllm for rocm

[heyselbi]

Description

ROCM Build fails with

[8/8] STEP 4/8: RUN --mount=type=cache,target=/root/.cache/pip     --mount=type=cache,target=/root/.cache/uv     --mount=type=bind,from=build_vllm,src=/workspace/dist,target=/install/vllm/     HOME=/root uv pip install         "$(echo /install/vllm/*.whl)[audio,video,tensorizer]"         vllm-tgis-adapter==${VLLM_TGIS_ADAPTER_VERSION}
Using Python 3.12.9 environment at: /opt/vllm
  × No solution found when resolving dependencies:
  ╰─▶ Because only vllm[audio]==0.1.dev8486+ga2a0e2a.rocm634 is available
      and vllm-tgis-adapter==0.8.0 depends on vllm>=0.10.0, we can conclude
      that vllm-tgis-adapter==0.8.0 and all versions of vllm[audio] are
      incompatible.
      And because you require vllm-tgis-adapter==0.8.0 and vllm[audio], we can
      conclude that your requirements are unsatisfiable.

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Chores
  • Updated the "vllm" dependency to remove the minimum version requirement.

[coderabbitai]

Walkthrough

The version constraint for the "vllm" dependency in the pyproject.toml file was removed. The dependency is now listed without a minimum version requirement, while all other dependencies and configurations remain unchanged.

Changes

Cohort / File(s)	Change Summary
Dependency Version Update pyproject.toml	Removed the minimum version constraint for the "vllm" dependency, changing from "vllm>=0.10.0" to "vllm"; no other changes made.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A hop and a skip, dependencies freed,
Version locks gone, the code can proceed.
No longer confined to a single track,
Now "vllm" can leap forward or back!
With every constraint that we let go,
The garden of code continues to grow. 🥕

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 516f857 and d982fa2.

📒 Files selected for processing (1)

• pyproject.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: tests (ubuntu-latest, 3.12, git+https://github.com/vllm-project/vllm@main)
• GitHub Check: tests (ubuntu-latest, 3.12, git+https://github.com/vllm-project/[email protected])

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-vllm-constr

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dtrifiro]

We need at least vllm>=0.7.2