Skip to content

Comments

fix: s3 path join method#1370

Merged
myhloli merged 1 commit intoopendatalab:devfrom
icecraft:fix/path_delimiter
Dec 27, 2024
Merged

fix: s3 path join method#1370
myhloli merged 1 commit intoopendatalab:devfrom
icecraft:fix/path_delimiter

Conversation

@icecraft
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. fix s3 path join method

Modification

  1. fix s3 path join method

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@myhloli myhloli merged commit e72709c into opendatalab:dev Dec 27, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
@icecraft icecraft deleted the fix/path_delimiter branch January 6, 2025 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants