Skip to content

feat(model_init): implement license verification for Ascend plugin#1737

Merged
myhloli merged 1 commit intoopendatalab:devfrom
myhloli:dev
Feb 21, 2025
Merged

feat(model_init): implement license verification for Ascend plugin#1737
myhloli merged 1 commit intoopendatalab:devfrom
myhloli:dev

Conversation

@myhloli
Copy link
Collaborator

@myhloli myhloli commented Feb 21, 2025

  • Add license verification logic for Ascend plugin
  • Handle different license-related exceptions with appropriate error messages
  • Log success message with license expiration date if verification passes
  • Fall back to CPU model if license verification fails or plugin is not available

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

- Add license verification logic for Ascend plugin
- Handle different license-related exceptions with appropriate error messages
- Log success message with license expiration date if verification passes
- Fall back to CPU model if license verification fails or plugin is not available
@myhloli myhloli merged commit c0d7e09 into opendatalab:dev Feb 21, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant