-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Dev #4473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #4473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the PDF rendering timeout mechanism by replacing per-task timeout with a global timeout and adds configurable process count control for PDF rendering operations.
Changes:
- Refactored timeout handling in
load_images_from_pdf()to usewait()with a single global timeout instead of individual future timeouts - Added
MINERU_PDF_RENDER_THREADSenvironment variable to control the number of processes used for PDF rendering - Implemented explicit process termination logic using signals for better cleanup on timeout or errors
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| mineru/utils/pdf_image_tools.py | Refactored timeout handling to use global timeout with wait(), added configurable threads parameter with environment variable support, and implemented explicit process termination using signals |
| mineru/utils/os_env_config.py | Added get_load_images_threads() function to read the MINERU_PDF_RENDER_THREADS environment variable |
| docs/zh/usage/cli_tools.md | Added documentation for the new MINERU_PDF_RENDER_THREADS environment variable and clarified platform support |
| docs/en/usage/cli_tools.md | Added documentation for the new MINERU_PDF_RENDER_THREADS environment variable and improved wording for existing entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: