fix recalculation bug in match_gt2pred_quick #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
非常感谢，我们先测试一下代码，如果没有问题的话接入最新一版验证代码中。 |
Collaborator
|
您好，感谢您贡献的代码。我们测试了几个模型，目前对前几名预测比较准确的模型来说分数影响不大。但出于严谨考虑，我们需要将所有的模型全部用最新代码跑一遍并确认结果后统一更新榜单，再一并合入这个PR，因此我们会等下一个版本的更新一起放，请不要关闭该PR，后续我们准备好版本更新后会进行合并，再次感谢。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复issue#64:当unmatched_pred_indices为空时，convert_final_matches函数会向converted_results中添加pred为空的条目，这些条目在merge_duplicates_add_unmatched中被计算了两次，主要漏洞在于match_quick.py第148行结束后没有将gt下标加入到processed_gt，提交的代码修复了这一问题