Fix incorrect column name in bulk_container.php count query#1649
Open
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Open
Fix incorrect column name in bulk_container.php count query#1649lacatoire wants to merge 1 commit intoopendcim:masterfrom
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Conversation
The count() was referencing RowID which does not exist in fac_CabRow table. The correct column name is CabRowID, matching the table's primary key. This was causing a 500 error on bulk container import. Fixes opendcim#1519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
count(RowID)tocount(CabRowID)in the SQL query at line 226 ofbulk_container.phpRowIDcolumn does not exist infac_CabRowtable; the correct primary key column isCabRowIDFixes #1519