Fix custom device status colors not showing in row view#1650
Open
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Open
Fix custom device status colors not showing in row view#1650lacatoire wants to merge 1 commit intoopendcim:masterfrom
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Conversation
All custom status colors now get !important on their CSS background-color rule, not just Reserved. Without this, department colors (generated later in the stylesheet) would always override custom status colors due to CSS cascade order. Fixes opendcim#1165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!importantto all custom device status color CSS rules inrowview.php, not just theReservedstatusReservedstatus was the only one working because it was the only one with!importantFixes #1165
Fixes #1582