Fix Add Link OK button not working in device notes editor#1655
Open
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Open
Fix Add Link OK button not working in device notes editor#1655lacatoire wants to merge 1 commit intoopendcim:masterfrom
lacatoire wants to merge 1 commit intoopendcim:masterfrom
Conversation
When no text was selected before clicking Add Link in the jQuery TE editor, the selected2link function's else branch did not call replaceSelection to mark an element with the setdatalink attribute. This caused linkRecord (triggered by the OK button) to find no marked elements and silently do nothing. Now replaceSelection is called in all cases so the link can be inserted even without a prior selection. Fixes opendcim#1431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selected2linkfunction was not callingreplaceSelectionwhen no text was pre-selected, so no element received thesetdatalinkmarker attributelinkRecord) searches for elements with that attribute and found nothing, causing the silent failurereplaceSelectioncall in the else branchFixes #1431