fix release manager rollout image listing when using Helm#1182
Merged
fix release manager rollout image listing when using Helm#1182
Conversation
gerardcl
requested review from
BraisVQ,
faust2199,
jafarre-bi,
kuebler,
metmajer,
oalyman and
renedupont
gerardcl
force-pushed
the
feature/fix-release-manager-rollout-image-listing
branch
from
8d4066f to
52062e2
Compare
henrjk
reviewed
Jan 7, 2025
henrjk
reviewed
Jan 7, 2025
henrjk
reviewed
Jan 7, 2025
henrjk
reviewed
Jan 7, 2025
Member
henrjk
left a comment
henrjk
left a comment
There was a problem hiding this comment.
Nice @gerardcl!
Overall this code looks good to me (if it works when running test). I have a few minor suggestions which you could adopt at your discretion.
Also wanted to make you aware of PR #1143 which touches the same files although I am not sure what the latest status is.
Perhaps the changes you are suggesting would also make sense in DeployOdsComponent which currently is flaky for Helm deployments.
jafarre-bi
reviewed
Jan 17, 2025
Contributor
jafarre-bi
left a comment
jafarre-bi
left a comment
There was a problem hiding this comment.
@gerardcl For your consideration. If it's good for you the way it is, it's also good for me.
jafarre-bi
approved these changes
Jan 23, 2025
Contributor
jafarre-bi
left a comment
jafarre-bi
left a comment
There was a problem hiding this comment.
Good job, @gerardcl !
gerardcl
deleted the
feature/fix-release-manager-rollout-image-listing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to opendevstack/ods-quickstarters#1013 , as this bug must be fixed.
The issue happens rarely but impacts the use of Helm strategy within the Release Manager usage; it is a race condition happening when having rollout defined as deployment strategy, and with the provided fix we make sure we always get the latest expected image.
FYI, the fix has also been tested internally, thanks to @BraisVQ