Enhance Helm strategy and support of Statefullset/Cronjob#1253
Merged
Enhance Helm strategy and support of Statefullset/Cronjob#1253
Conversation
… types and update method signatures for better flexibility
… tracked deployments logic
… types and improve Helm deployment resource handling
…omments for clarity on supported Kubernetes workload types
…Helm and Tailor deployment strategies
…Component to ensure consistent image string extraction and improve deployment data organization
…rings in FinalizeOdsComponent and DeploymentDescriptor
…ng for Helm and Tailor deployment strategies
… in HelmDeploymentStrategy
- Removed unused PodData import from DeployOdsComponent.groovy. - Simplified component selector handling in FinalizeOdsComponent.groovy. - Enhanced image validation logic in FinalizeOdsComponent.groovy. - Updated HelmDeploymentStrategySpec to use simpler map structures for expected rollout data. - Refactored pod data handling in HelmDeploymentStrategySpec to use container images directly from pod specs. - Added tests for various resource types including StatefulSet and CronJob in HelmDeploymentStrategySpec. - Improved FixtureHelper to create detailed Helm status maps for different resource types. - Updated OpenShiftServiceSpec to test getContainerImagesWithNameFromPodSpec for multiple container scenarios. - Adjusted OdsComponentStageRolloutOpenShiftDeploymentSpec to reflect new data structures and improve clarity.
BraisVQ
changed the title
angelmp01
reviewed
Jan 14, 2026
Contributor
Author
|
Checked generated TIR document and it is properly generated with the correct content. |
Member
|
great job @BraisVQ, thanks for making this happen!!! 🚀 |
…roved type safety
hrcornejo
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this PR, I made the following changes to the Helm implementation and maintained Tailor working as it was before:
Tested successfully with the following setup in Release Manager: