Fix branch mapping logic to ensure correct environment assignment#1263
Open
EamonnODonnell wants to merge 3 commits intoopendevstack:masterfrom
Open
Fix branch mapping logic to ensure correct environment assignment#1263EamonnODonnell wants to merge 3 commits intoopendevstack:masterfrom
EamonnODonnell wants to merge 3 commits intoopendevstack:masterfrom
Conversation
hrcornejo
requested review from
hrcornejo,
jafarre-bi,
jordivx and
jorge-romero
Contributor
|
Please @EamonnODonnell fix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared library was not handling branchToMapping properly. Branches whose name starts with branches defined in the branchToEnvironmentMapping property AND where there was NO exact match listed in the branchToEnvironmentMapping property would attempt to deploy rather than skip deployment (as no environment mapped).
The code change enforces that branches defined in the branchToEnvironmentMapping property that do not end with "/" should require an exact match before triggering a deployment