Feature/retrieve debug information#913
Draft
victorpablosceruelo wants to merge 7 commits intomasterfrom
Draft
Conversation
added 7 commits
April 22, 2022 12:12
Contributor
Author
|
I would like to have a discussion on the contents of this PR. It would be an improvement to have it into master and being able to export information from pipelines using previous versions and compare results to new ones. Maybe the idea of keeping the files in Jenkins is not good enough (we might be able to find another place to store them) and the idea of running it always is not good enough too, but I think that the idea of being able to ensure that after a change the resulting documents are similar enough is something we need. @jorge-romero @jafarre-viewnext, what do you think about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppose we could have a test that takes as input the url to a job in production, take from it the real values it uses and run the important (and problematic to test) parts of the shared library using that values.
This is what we propose to do. Here we only have the part in which we save the important values of a pipeline execution into a text file that we can easily retrieve from a test. Retrieving this test file as input data and the output of the pipeline allows us to compare results between current implementation in production and current development version of shared library.
This development started during the docGen refactor, task in which we invested a lot of effort and which was left appart because we had no way to justify what was still missing.
The first usage we have in mind is comparing the result of a pipeline without the docGen refactor and the result of a pipeline with it implemented, so we can compare results of multiple calls to docGen from the shared library.
It is rather interesting to include it in master before refactors like the ones proposed in:
https://github.com/opendevstack/ods-jenkins-shared-library/tree/feature/afterMoveLevaDoc
https://github.com/opendevstack/ods-document-generation-svc/tree/feature/moveLevaDoc
The only drawback of this proposal is that it generates another file in the pipeline that needs to be stored by Jenkins if jenkins keep executions of pipelines, but the size of this file is less than 1/2 mb.