Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Adding flyout to create detector from existing monitor through Monitor Details page #180

Open
amitgalitz wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Adding flyout to create detector from existing monitor through Monitor Details page #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d12f05d
intial flyout works for success case
Aug 12, 2020
dff2b50
first iteration of design works
Aug 20, 2020
c2ca4bb
changed flyout to be an editable form
Aug 21, 2020
5704639
working presentation frontend
Aug 31, 2020
f4dcf20
minor fix
Aug 31, 2020
c2cb627
Merge branch 'master' into adeverywhere_second_design
Aug 31, 2020
3553e39
refactored code
Aug 31, 2020
a9b6685
more refactoring and cleaning
Aug 31, 2020
290bddc
added constants for hardcoded numbers and other refactoring
Aug 31, 2020
f854f7d
spacing changes
Aug 31, 2020
3121545
delete draft file
Sep 1, 2020
9df1f66
updated to work with Kibana 7.9
Sep 1, 2020
bb3fb70
updated unit test snapshots
Sep 1, 2020
8a714b8
1st round of changes, added constants and fixed some typos
Sep 2, 2020
0bedc2e
more small changes in naming and comments
Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion public/components/Flyout/Flyout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ const Flyout = ({ flyout, onClose }) => {
} = flyoutData;

const flyoutHeader = header && <EuiFlyoutHeader {...headerProps}>{header}</EuiFlyoutHeader>;
const flyoutBody = body && <EuiFlyoutBody {...bodyProps}>{body}</EuiFlyoutBody>;
const flyoutBody = body && (
<EuiFlyoutBody onClose={onClose} {...bodyProps}>
{body}
</EuiFlyoutBody>
);
const flyoutFooter = footer && <EuiFlyoutFooter {...footerProps}>{footer}</EuiFlyoutFooter>;

return (
Expand Down
4 changes: 3 additions & 1 deletion public/components/Flyout/__snapshots__/Flyout.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ exports[`Flyout renders 1`] = `
</h2>
</EuiTitle>
</EuiFlyoutHeader>
<EuiFlyoutBody>
<EuiFlyoutBody
onClose={[MockFunction]}
>
<EuiText
style={
Object {
Expand Down
Loading