Skip to content

[Fix MWEM.py] Removed deprecated numpy .product() call #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix MWEM.py] Removed deprecated numpy .product() call #611

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a0333d
[Fix MWEM.py] Removed deprecated numpy .product() call
lucid-jake Dec 2, 2024
355e7cc
Update mwem.py
lucid-jake Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion synth/snsynth/mwem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ def _histogram_from_data_attributes(self, data, splits=[]):
# our ranges above
if any([a > 0 for a in mins_data]):
warnings.warn("Data should be preprocessed to have 0 based indices.")
dimensionality = np.product(dims_sizes)
dimensionality = np.prod(dims_sizes)
if dimensionality > 1e8:
warnings.warn(f"Dimensionality of histogram is {dimensionality:,}, consider using splits.")
histogram, bins = np.histogramdd(split_data, bins=dims_sizes)
Expand Down