Update deployment.yaml #284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need deployments have their specific namespaces Signed-off-by: Amin Maghsodi <[email protected]>
| metadata: | ||
| name: {{ template "localpv.fullname" . }} | ||
| {{- with .Values.localpv.annotations }} | ||
| namespace: {{ .Release.Namespace }} |
Member
There was a problem hiding this comment.
Isn't this just default? From your description thought you'd want to pass some other var for the namespace
Member
There was a problem hiding this comment.
Got it now, for the helm template... could you please also add it to the service account?
Member
|
@aminmaghsodi if you execute your helm install command with |
Author
|
@niladrih You see many blocks (e.g. Deployment block) does not have namespace: openebs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need deployments have their specific namespaces.
if you run commands:
helm show values openebs/openebs > values.yaml
helm template openebs openebs/openebs --namespace openebs -f values.yaml > openebs-generated-values.yaml
You see many blocks (for example this Deployment block) does not have namespace: openebs