Merged
Conversation
added 8 commits
July 22, 2025 00:28
- project: go/oeco-sdk/v2beta 0.14.0
- project: go/oeco-sdk/v2beta 0.15.0
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| link.classList.remove(ACTIVE_CLASS); | ||
| last = document.createElement('li') as ListItem; | ||
| let text = tmp.lastElementChild.textContent.trim(); | ||
| last.innerHTML = `<a class="DocsTableOfContents-link" href="#${tmp.id}">${text}</a>`; |
Check failure
Code scanning / CodeQL
DOM text reinterpreted as HTML High documentation
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To fix the issue, the textContent value should be properly escaped before being interpolated into the HTML string. Escaping ensures that any special characters in the text (e.g., <, >, &) are converted into their corresponding HTML entities, preventing them from being interpreted as HTML or JavaScript. This can be achieved by using a utility function to escape the text before embedding it into the HTML.
The fix involves:
- Adding a utility function to escape HTML special characters.
- Replacing the direct interpolation of
textin line 32 with the escaped version oftext.
Suggested changeset
1
apps/web/public/docs/v2alpha/assets/contents.ts
| @@ -5,2 +5,11 @@ | ||
| const ACTIVE_CLASS = 'DocsTableOfContents-link-active'; | ||
| function escapeHtml(unsafe: string): string { | ||
| return unsafe | ||
| .replace(/&/g, "&") | ||
| .replace(/</g, "<") | ||
| .replace(/>/g, ">") | ||
| .replace(/"/g, """) | ||
| .replace(/'/g, "'"); | ||
| } | ||
|
|
||
| export function toc() { | ||
| @@ -31,3 +40,3 @@ | ||
| let text = tmp.lastElementChild.textContent.trim(); | ||
| last.innerHTML = `<a class="DocsTableOfContents-link" href="#${tmp.id}">${text}</a>`; | ||
| last.innerHTML = `<a class="DocsTableOfContents-link" href="#${tmp.id}">${escapeHtml(text)}</a>`; | ||
| container.appendChild(last); |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.