Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Conversation

@dcoa
Copy link
Contributor

@dcoa dcoa commented Apr 2, 2025

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description
This PR updates frontend app publisher to support CSS variables and the corresponding paragon design tokens.

Changes implemented

  • Replace Paragon SCSS variables with CSS variables.
  • Update deprecated components

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 2, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/2u-phoenix.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 2, 2025
@dcoa
Copy link
Contributor Author

dcoa commented Apr 2, 2025

@brian-smith-tcril this MFE has as dependency edx component footer (which was considered out of the scope from beginning), before making any change, how do you like to proceed?

@brian-smith-tcril
Copy link
Contributor

@dcoa what happens if the dependency is changed from https://github.com/edx/frontend-component-footer-edx to https://github.com/openedx/frontend-component-footer on master?

If the MFE still works as expected then I think PRing that change would be the best path forward. Someone at 2U would likely need to update a deploy script to alias in footer-edx, but that alias is not something that should be in the upstream package.json.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 2, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from e383b85 to 8e7c0c2 Compare April 23, 2025 00:05
@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.37%. Comparing base (f8e0ee8) to head (200e7b0).
Report is 1 commits behind head on master-design-tokens.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           master-design-tokens    #1003   +/-   ##
=====================================================
  Coverage                 62.37%   62.37%           
=====================================================
  Files                       131      131           
  Lines                      3338     3338           
  Branches                    961      963    +2     
=====================================================
  Hits                       2082     2082           
  Misses                     1211     1211           
  Partials                     45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa requested a review from brian-smith-tcril April 23, 2025 00:44
@dcoa dcoa marked this pull request as ready for review April 23, 2025 00:44
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 8e7c0c2 to 8391573 Compare April 28, 2025 03:48
@dcoa dcoa changed the title [WIP]feat: design tokens support feat: design tokens support Apr 30, 2025
@dcoa
Copy link
Contributor Author

dcoa commented May 1, 2025

the error in codecov patch is related to an unchanged file.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to do exhaustive testing of this locally as it requires a bit more tutor fiddling than I had time for, but what I was able to test is looking great!

I'm happy to merge this once it is rebased, but I'd also like to ask @MaxFrank13 and @adamstankiewicz if they know someone at 2U that would like to take a look first.

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 8391573 to 807e736 Compare May 9, 2025 16:11
@ihor-romaniuk
Copy link

ihor-romaniuk commented May 9, 2025

Hello everyone,
I’ve posted a comment on the brand-openedx package pull request: openedx/brand-openedx#26 (comment).
Kindly review it before merging this and any related pull requests concerning design tokens.
Thank you!

@brian-smith-tcril
Copy link
Contributor

Hello everyone, I’ve posted a comment on the brand-openedx package pull request: openedx/brand-openedx#26 (comment). Kindly review it before merging this and any related pull requests concerning design tokens. Thank you!

Hello!

I'm happy to see someone invested in the implications of design tokens!

I responded to your comment openedx/brand-openedx#26 (comment) on the brand-openedx PR with some information that I hope will clarify/ease the concerns you've expressed.

While I understand the desire to pause the merging of these PRs until everything is clear, I'd like to point out that these PRs are not landing directly onto master, but instead into new master-design-tokens feature branches, and there will still be plenty of time to discuss the concerns before those feature branches land on master.

I'd also like to clarify that while Paragon 23 is a breaking change insofar as current brand packages will not work with it, it does not remove any theming capabilities from site operators.

I'm looking forward to discussing this with you more!

Thanks!

@dcoa
Copy link
Contributor Author

dcoa commented May 19, 2025

@adamstankiewicz @MaxFrank13 just a friendly remainder over this PR

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label May 19, 2025
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

@brian-smith-tcril brian-smith-tcril changed the base branch from master to master-design-tokens May 21, 2025 16:31
@brian-smith-tcril
Copy link
Contributor

@dcoa looks like this one has some conflicts. I've already created the master-design-tokens branch so this can land immediately once the conflicts are resolved!

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 807e736 to 200e7b0 Compare May 22, 2025 02:28
@dcoa
Copy link
Contributor Author

dcoa commented May 22, 2025

@brian-smith-tcril rebased, thank you :)

@brian-smith-tcril brian-smith-tcril merged commit e06e359 into openedx-unsupported:master-design-tokens May 22, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants