-
Notifications
You must be signed in to change notification settings - Fork 58
feat: design tokens support #1003
feat: design tokens support #1003
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@brian-smith-tcril this MFE has as dependency edx component footer (which was considered out of the scope from beginning), before making any change, how do you like to proceed? |
|
@dcoa what happens if the dependency is changed from https://github.com/edx/frontend-component-footer-edx to https://github.com/openedx/frontend-component-footer on If the MFE still works as expected then I think PRing that change would be the best path forward. Someone at 2U would likely need to update a deploy script to alias in |
e383b85 to
8e7c0c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #1003 +/- ##
=====================================================
Coverage 62.37% 62.37%
=====================================================
Files 131 131
Lines 3338 3338
Branches 961 963 +2
=====================================================
Hits 2082 2082
Misses 1211 1211
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e7c0c2 to
8391573
Compare
|
the error in codecov patch is related to an unchanged file. |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to do exhaustive testing of this locally as it requires a bit more tutor fiddling than I had time for, but what I was able to test is looking great!
I'm happy to merge this once it is rebased, but I'd also like to ask @MaxFrank13 and @adamstankiewicz if they know someone at 2U that would like to take a look first.
8391573 to
807e736
Compare
|
Hello everyone, |
Hello! I'm happy to see someone invested in the implications of design tokens! I responded to your comment openedx/brand-openedx#26 (comment) on the While I understand the desire to pause the merging of these PRs until everything is clear, I'd like to point out that these PRs are not landing directly onto I'd also like to clarify that while Paragon 23 is a breaking change insofar as current brand packages will not work with it, it does not remove any theming capabilities from site operators. I'm looking forward to discussing this with you more! Thanks! |
|
@adamstankiewicz @MaxFrank13 just a friendly remainder over this PR |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this!
|
@dcoa looks like this one has some conflicts. I've already created the |
807e736 to
200e7b0
Compare
|
@brian-smith-tcril rebased, thank you :) |
e06e359
into
openedx-unsupported:master-design-tokens
Warning
This PR should not be merge to
masterdirectly, it should point tomaster-design-tokensonce the branch has been created.Description
This PR updates frontend app publisher to support CSS variables and the corresponding paragon design tokens.
Changes implemented