Skip to content

chore: fix timing issue with logging overrides #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deborahgu merged 1 commit into from
Dec 6, 2024
Merged

chore: fix timing issue with logging overrides #2660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions credentials/settings/production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@

ALLOWED_HOSTS = ["*"]

LOGGING_FORMAT_STRING = ""
LOGGING = get_logger_config(format_string=LOGGING_FORMAT_STRING)

# Keep track of the names of settings that represent dicts. Instead of overriding the values in base.py,
# the values read from disk should UPDATE the pre-configured dicts.
DICT_UPDATE_KEYS = ("JWT_AUTH",)
Expand Down Expand Up @@ -50,6 +47,9 @@
# Load the files storage backend settings for django storages
vars().update(FILE_STORAGE_BACKEND)

# make sure this happens after the configuration file overrides so format string can be overridden
LOGGING = get_logger_config(format_string=LOGGING_FORMAT_STRING)

Comment on lines +50 to +52
Copy link
Contributor

@justinhynes justinhynes Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:bonks own forhead: yeah, this makes sense 🤞

if "EXTRA_APPS" in locals():
INSTALLED_APPS += EXTRA_APPS

Expand Down
Loading