-
Notifications
You must be signed in to change notification settings - Fork 62
feat: added atlas translations flow in enterprise app #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
nsprenkle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is diverging from stated approach for translations (see OEP-58: Translations Management).
Please update to match desired translation pattern
aea8bc8 to
ac3062f
Compare
ac3062f to
7598b5e
Compare
7598b5e to
ef0478d
Compare
nsprenkle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I would verify with a code owner (for specific domain context) and @deborahgu who knows more about this particular i18n setup.
ef0478d to
7f47190
Compare
7f47190 to
9784dea
Compare
Merge checklist:
requirements/*.txtfiles)base.inif needed in production but edx-platform doesn't install ittest-master.inif edx-platform pins it, with a matching versionmake upgrade && make requirementshave been run to regenerate requirementsmake statichas been run to update webpack bundling if any static content was updated./manage.py makemigrationshas been run./manage.py lms makemigrationsin the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgradein edx-platform will look for the latest version in PyPi.