Skip to content

Conversation

@jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Jan 6, 2026

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • Trigger the 'Upgrade one Python dependency' action against master in edx-platform with new version number to generate version bump PR
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

Copy link

@nsprenkle nsprenkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is diverging from stated approach for translations (see OEP-58: Translations Management).

Please update to match desired translation pattern

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-11102 branch 2 times, most recently from aea8bc8 to ac3062f Compare January 8, 2026 09:47
@jajjibhai008 jajjibhai008 changed the title feat: added spanish tranlatiosn mo files for enterprise app feat: added atlas translations flow in enterprise app Jan 8, 2026
@jajjibhai008 jajjibhai008 requested a review from nsprenkle January 8, 2026 09:48
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-11102 branch from 7598b5e to ef0478d Compare January 8, 2026 19:21
Copy link

@nsprenkle nsprenkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I would verify with a code owner (for specific domain context) and @deborahgu who knows more about this particular i18n setup.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-11102 branch from ef0478d to 7f47190 Compare January 8, 2026 20:00
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-11102 branch from 7f47190 to 9784dea Compare January 8, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants