feat: [FC-7879] implement get_user_dates() method to get all user dates for a course#326#346
Conversation
|
Thanks for the pull request, @kyrylo-kh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| dates[key] = content_date.user_overrides[0].actual_date | ||
| else: | ||
| try: | ||
| dates[key] = content_date.policy.actual_date() |
There was a problem hiding this comment.
I notice that this call is without arguments, compared to this:
Line 251 in ab2ee71
Has this been tested with self-paced courses?
There was a problem hiding this comment.
Currently get_user_dates only resolves absolute policy dates here. Relative dates are skipped (MissingScheduleError is caught). So self-paced (relative) policy dates aren’t returned by this API
| return schedules | ||
|
|
||
|
|
||
| def get_user_dates(course_id, user_id, block_types=None, block_keys=None, date_types=None): |
There was a problem hiding this comment.
I'm trying to grok how this function and [get_dates_for_course()](https://github.com/openedx/edx-when/blob/ab2ee71af64ee6ef720083586eb26e1f58a748d9/edx_when/api.py#L163) relate. Given that there is some repeated code, is there a cleaner refactoring that's possible?
There was a problem hiding this comment.
get_user_dates is a narrow, filterable API for one user. get_dates_for_cours is the full path with caching, subsection filtering, and relative dates. The shared part is that loop that turns content dates into policy dates and applies user overrides. A cleaner approach would be to extract that into a small helper and have both call it (and pass schedule/end/cutoff from the helper so self-paced works in both). Would you like to have such helper function in this PR?
dbb6a9c to
08ca4c1
Compare
b4852bb to
4a63da5
Compare
Description
This PR adds a new API function
get_user_dates(course_id, user_id)to return a comprehensive map of dates for a given course and user.Functionality
Returns a dictionary where keys are
(block_key, field)tuples and values aredatetimeobjects.Prioritizes user-specific overrides (
UserDate) over default content dates (ContentDatewithDatePolicy).Supports optional filtering by:
block_types(e.g.,sequential,vertical)block_keys(UsageKey or string list)date_types(due,start, etc.)Features
Testing
Extensive test suite verifies: