feat: allow logging format to be overridden #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of ENT-10092 to correlate logs with DataDog traces, we need the ability to add trace/span IDs to the log lines. However, this being an open source project, we cannot assume a particular format and observability tool. Hence the need to allow operators to completely override the log format. ENT-10092
iloveagent57
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ENT-10092 to correlate logs with DataDog traces, we need the ability to add trace/span IDs to the log lines. However, this being an open source project, we cannot assume a particular format and observability tool. Hence the need to allow operators to completely override the log format.
ENT-10092
Context
This approach borrows from the one implemented for credentials last year: