-
Notifications
You must be signed in to change notification settings - Fork 175
feat: put account settings into cards #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: put account settings into cards #1368
Conversation
|
Sandbox deployment failed 💥 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 68.25% 68.28% +0.02%
==========================================
Files 120 120
Lines 2372 2371 -1
Branches 655 655
==========================================
Hits 1619 1619
- Misses 707 708 +1
+ Partials 46 44 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sandbox deployment failed 💥 |
|
@brian-smith-tcril this looks great! Is it supported for these components to reduce/adjust the vertical padding within each card? The vertical spacing seems a bit high, especially the gap before the help text at the bottom. For reference, here's the Indigo theme style for this view, which I think has a more balanced padding:
|
|
@sdaitzman I updated it to this in a50e72a I'm not sure why the screenshot is missing the right edge, I usually just use my desktop environment's screenshot tool but decided to try using chrome's dev tools screenshot to get the whole page this time.
|
|
Re:
In a50e72a I only changed the margins on the content within the cards, so the actual card components still have their default padding. |
|
Sandbox deployment failed 💥 |
|
One thing I'm not a huge fan of (and likely need some historical context on) is the difference in margin between Paragon's https://paragon-openedx.netlify.app/components/card/#actions
I assume the goal was to have them aligned at the bottom, but it's always felt like the title was "low" to me. Made an issue on the Paragon repo to look into it openedx/paragon#3963 |
|
Sandbox deployment successful 🚀 |
|
This looks great! Both from a code and visual perspective! It’s really nice to see that we’re moving away from custom markup in favor of Paragon components. |




Description
Using Paragon components to replicate some of the style overrides done by the Indigo theme (see https://openedx.atlassian.net/wiki/spaces/OEPM/pages/5278400519/Account+Page)
Sandbox:
🎓 LMS
📝 Studio
Screenshots
Merge Checklist
Post-merge Checklist