-
Notifications
You must be signed in to change notification settings - Fork 4
backport for fixing base breadcrumb item with no link set #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport for fixing base breadcrumb item with no link set #34
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@farhaanbukhsh: can you give us a hand with this backport? Thanks :) |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✅ I tested this on Ulmo tutor devstack
✅ I read through the code
❌ I checked for accessibility issues
❌ Includes documentation
|
@jacobo-dominguez-wgu Just a nit can you fix the typo in your commit message from bradcrumb to breadcrumb? |
ab55031 to
df0fcd5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/ulmo #34 +/- ##
================================================
+ Coverage 94.32% 94.34% +0.01%
================================================
Files 44 44
Lines 881 884 +3
Branches 176 155 -21
================================================
+ Hits 831 834 +3
Misses 48 48
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@farhaanbukhsh Done, thanks! |
Description
This is a backport for the release/ulmo branch of #32.
Adding url link to “Manage Access” breadcrumb item and adding unit test to support this modification.
It closes #29
Demo video
Grabacion.de.pantalla.2025-11-04.a.la.s.2.24.01.p.m.mov
How to test it
npm install && npm run devhttp://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>Editlink on one of the users in the team members table or go tohttp://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>/<username>Manage Accessitem on the breadcrumb.http://apps.local.openedx.io:2025/admin-console/authz/libraries/<YOUR_LIB_ID>page