Skip to content

Conversation

@jacobo-dominguez-wgu
Copy link
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Nov 14, 2025

Description

Updating namespaces to permissions to use name spaced identifiers by adding the content_libraries prefix.
Example:
Before: delete_library
After content_libraries.delete_library

The permissions used/mocked on the unit tests were also modified to keep consistency.
Closes #35
Related to: openedx/openedx-authz#136

Also had to add ts-jest as devDependency to fix broken test workflow:

Run npm run test

> @openedx/[email protected] test
> fedx-scripts jest --coverage --passWithNoTests

Running with resolved config:
/home/runner/work/frontend-app-admin-console/frontend-app-admin-console/jest.config.js

● Validation Error:

  Module ts-jest in the transform option was not found.
         <rootDir> is: /home/runner/work/frontend-app-admin-console/frontend-app-admin-console

  Configuration Documentation:
  https://jestjs.io/docs/configuration

Error: Process completed with exit code 1.

Important

Dependency

openedx/openedx-authz#142

How to test it

Make sure you are running openedx-authz v0.16.0

  • Clone this branch
  • npm install && npm run dev
  • Verify the roles and permission tabs display correct information

Screenshots of the Roles and Permission tabs

Before After
Captura de pantalla 2025-11-14 a la(s) 11 15 44 a m Captura de pantalla 2025-11-14 a la(s) 11 03 46 a m
Captura de pantalla 2025-11-14 a la(s) 11 15 58 a m Captura de pantalla 2025-11-14 a la(s) 11 03 58 a m
Captura de pantalla 2025-11-14 a la(s) 11 16 03 a m Captura de pantalla 2025-11-14 a la(s) 11 04 06 a m
Captura de pantalla 2025-11-14 a la(s) 11 15 18 a m Captura de pantalla 2025-11-14 a la(s) 11 03 23 a m

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 14, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Nov 14, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu force-pushed the updating-permissions-namespaces branch from 9452058 to cb19377 Compare November 14, 2025 18:22
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.34%. Comparing base (b760584) to head (99a691e).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   94.33%   94.34%           
=======================================
  Files          44       44           
  Lines         883      884    +1     
  Branches      155      155           
=======================================
+ Hits          833      834    +1     
  Misses         48       48           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Ready for Review in Contributions Nov 14, 2025
@jacobo-dominguez-wgu
Copy link
Contributor Author

Does it need to be backported to release/ulmo?

@jacobo-dominguez-wgu
Copy link
Contributor Author

Does it need to be backported to release/ulmo?

Here is the backported pr #38

@MaferMazu MaferMazu linked an issue Nov 14, 2025 that may be closed by this pull request
{ key: 'view_library', label: 'view', resource: 'library' },
{ key: 'edit_library', label: 'edit', resource: 'library' },
{ key: 'content_libraries.view_library', label: 'view', resource: 'library' },
{ key: 'content_libraries.edit_library', label: 'edit', resource: 'library' },
Copy link
Contributor

@MaferMazu MaferMazu Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ key: 'content_libraries.edit_library', label: 'edit', resource: 'library' },
{ key: 'content_libraries.edit_library_content', label: 'edit', resource: 'library' },

Copy link
Contributor

@MaferMazu MaferMazu Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to define those permission strings as variables and use them to avoid misspellings or manual errors. In the long term, it should be valuable to extract those permissions to ensure consistency between the front and the back.

(Not a blocker)

Copy link
Contributor

@MaferMazu MaferMazu Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me. Thanks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been addressed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added const variables for the library permissions.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it's working as expected! Thank you so much for moving this forward :)

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the mock data in one of the tests is incorrect/misleading, as per @MaferMazu's comment.

{ key: 'view_library', label: 'view', resource: 'library' },
{ key: 'edit_library', label: 'edit', resource: 'library' },
{ key: 'content_libraries.view_library', label: 'view', resource: 'library' },
{ key: 'content_libraries.edit_library', label: 'edit', resource: 'library' },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been addressed?

@jacobo-dominguez-wgu jacobo-dominguez-wgu force-pushed the updating-permissions-namespaces branch from c6179c7 to b161291 Compare November 18, 2025 16:32
@jacobo-dominguez-wgu
Copy link
Contributor Author

Created const variables for the library permissions and updated all the references.
Also fix a race condition on a unit test that was sometimes failing and sometimes passing, used an act to fix it.

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arbrandes arbrandes merged commit a37491b into openedx:master Nov 18, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update content library permissions to use name spaced identifiers Namespace or app names in our permissions

5 participants