-
Notifications
You must be signed in to change notification settings - Fork 4
refactor: adding namespace to permissions #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adding namespace to permissions #37
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
…n-console into updating-permissions-namespaces
9452058 to
cb19377
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 94.33% 94.34%
=======================================
Files 44 44
Lines 883 884 +1
Branches 155 155
=======================================
+ Hits 833 834 +1
Misses 48 48
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does it need to be backported to release/ulmo? |
Here is the backported pr #38 |
| { key: 'view_library', label: 'view', resource: 'library' }, | ||
| { key: 'edit_library', label: 'edit', resource: 'library' }, | ||
| { key: 'content_libraries.view_library', label: 'view', resource: 'library' }, | ||
| { key: 'content_libraries.edit_library', label: 'edit', resource: 'library' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { key: 'content_libraries.edit_library', label: 'edit', resource: 'library' }, | |
| { key: 'content_libraries.edit_library_content', label: 'edit', resource: 'library' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to define those permission strings as variables and use them to avoid misspellings or manual errors. In the long term, it should be valuable to extract those permissions to ensure consistency between the front and the back.
(Not a blocker)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good to me. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added const variables for the library permissions.
mariajgrimaldi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and it's working as expected! Thank you so much for moving this forward :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but the mock data in one of the tests is incorrect/misleading, as per @MaferMazu's comment.
| { key: 'view_library', label: 'view', resource: 'library' }, | ||
| { key: 'edit_library', label: 'edit', resource: 'library' }, | ||
| { key: 'content_libraries.view_library', label: 'view', resource: 'library' }, | ||
| { key: 'content_libraries.edit_library', label: 'edit', resource: 'library' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been addressed?
c6179c7 to
b161291
Compare
|
Created const variables for the library permissions and updated all the references. |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
Updating namespaces to permissions to use name spaced identifiers by adding the
content_librariesprefix.Example:
Before:
delete_libraryAfter
content_libraries.delete_libraryThe permissions used/mocked on the unit tests were also modified to keep consistency.
Closes #35
Related to: openedx/openedx-authz#136
Also had to add ts-jest as devDependency to fix broken test workflow:
Important
Dependency
openedx/openedx-authz#142
How to test it
Make sure you are running openedx-authz v0.16.0
npm install&&npm run devScreenshots of the
RolesandPermissiontabs