Skip to content

[ENT-10849] Enable all filters for metrics on engagement and outcomes tab#1667

Merged
mahamakifdar19 merged 1 commit intomasterfrom
maham/ENT-10849
Sep 10, 2025
Merged

[ENT-10849] Enable all filters for metrics on engagement and outcomes tab#1667
mahamakifdar19 merged 1 commit intomasterfrom
maham/ENT-10849

Conversation

@mahamakifdar19
Copy link
Copy Markdown
Contributor

Ticket:
https://2u-internal.atlassian.net/browse/ENT-10849

Description:
This PR introduces several improvements and optimizations across the analytics V2.0

  • Enabled support for all filters in Stats/Metrics
  • Applied structural optimizations to reduce unnecessary re-renders and improve performance
  • Removed the Filters Context (no longer required)
  • Added lazy loading for tabs using mountOnEnter and unmountOnExit (tabs are now mounted/unmounted only when active)

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-10849 branch 2 times, most recently from e8c3cd5 to 127f0f3 Compare September 8, 2025 08:53
Base automatically changed from maham/ENT-10833 to master September 8, 2025 08:54
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.87%. Comparing base (1067f26) to head (f0d2681).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
- Coverage   86.88%   86.87%   -0.01%     
==========================================
  Files         798      797       -1     
  Lines       18139    18131       -8     
  Branches     3809     3791      -18     
==========================================
- Hits        15760    15752       -8     
  Misses       2301     2301              
  Partials       78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-10849 branch 2 times, most recently from 527f058 to 1db517c Compare September 8, 2025 09:05
@mahamakifdar19 mahamakifdar19 merged commit 4a6b0a3 into master Sep 10, 2025
9 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-10849 branch September 10, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants