Skip to content

fix: s/sept 30/sept 15/#1668

Merged
iloveagent57 merged 1 commit intomasterfrom
aed/dates
Sep 5, 2025
Merged

fix: s/sept 30/sept 15/#1668
iloveagent57 merged 1 commit intomasterfrom
aed/dates

Conversation

@iloveagent57
Copy link
Copy Markdown
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @iloveagent57!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 5, 2025
@iloveagent57 iloveagent57 enabled auto-merge (rebase) September 5, 2025 17:06
@iloveagent57 iloveagent57 merged commit 417c259 into master Sep 5, 2025
10 of 11 checks passed
@iloveagent57 iloveagent57 deleted the aed/dates branch September 5, 2025 17:46
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Sep 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.87%. Comparing base (6194418) to head (090a8b6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1668   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files         797      797           
  Lines       18105    18105           
  Branches     3778     3778           
=======================================
  Hits        15728    15728           
  Misses       2299     2299           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants