generated from openedx/frontend-template-application
-
Notifications
You must be signed in to change notification settings - Fork 246
fix: adding value length check for full name field #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmltaWt0
wants to merge
7
commits into
openedx:master
Choose a base branch
from
raccoongang:max/fix/name-max-lenght
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8e17638
fix: adding value length check for full name field
cmltaWt0 8bdc0bb
Merge branch 'master' into max/fix/name-max-lenght
cmltaWt0 ce3d2ea
refactor: replace magic number 255 with named constant
filippovskii09 bada5a7
Merge branch 'master' into max/fix/name-max-lenght
cmltaWt0 f6d14b0
fix: use translation in test
filippovskii09 42a19ef
Merge branch 'max/fix/name-max-lenght' of https://github.com/raccoong…
filippovskii09 ff8ebfb
Merge branch 'master' into max/fix/name-max-lenght
filippovskii09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
src/common-components/tests/__snapshots__/ThirdPartyAuthAlert.test.jsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -126,6 +126,11 @@ const messages = defineMessages({ | |
| defaultMessage: 'Enter a valid name', | ||
| description: 'Validation message that appears when fullname contain URL', | ||
| }, | ||
| 'name.validation.length.message': { | ||
| id: 'name.validation.message', | ||
| defaultMessage: 'Full name cannot be longer than 255 characters', | ||
|
||
| description: 'Validation message that appears when the full name exceeds the character limit', | ||
| }, | ||
| 'password.validation.message': { | ||
| id: 'password.validation.message', | ||
| defaultMessage: 'Password criteria has not been met', | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use translations here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed