feat: add fullscreen button to XBlock editor#2892
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
08a7c1e to
061f010
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2892 +/- ##
========================================
Coverage 95.39% 95.39%
========================================
Files 1331 1331
Lines 30585 30595 +10
Branches 6713 6933 +220
========================================
+ Hits 29177 29187 +10
+ Misses 1351 1339 -12
- Partials 57 69 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
061f010 to
6a6c8cf
Compare
navinkarkera
left a comment
There was a problem hiding this comment.
@rpenido Looks good. Just have one problem, the tiny-mce-editor doesn't seem to expand to take up the full space in fullscreen. I don't think it is a very simple problem as there is no clear option to dynamically resize the editor.
I tried to fix it, but the problem is that the tiny-mce-editor sets the editor css property 'height', even if we only set the 'min_height`. I didn't find a way to fix it. |
|
@rpenido It's missing a padding between the buttons
|
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good! There are some nits to fix before merging

Description
This PR adds a "Fullscreen" button to the XBlock editors.
Course Author
Supporting information
This PR is part of an initiative to improve the UI for editors with many configuration options.
Testing instructions
This editor is used in 3 places:
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'