Skip to content

feat: add fullscreen button to XBlock editor#2892

Merged
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4321/add-fullscreen-button-to-editor
Feb 27, 2026
Merged

feat: add fullscreen button to XBlock editor#2892
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:rpenido/fal-4321/add-fullscreen-button-to-editor

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 20, 2026

Description

This PR adds a "Fullscreen" button to the XBlock editors.

fullscreen-editor

  • Which user roles will this change impact?
    Course Author

Supporting information

This PR is part of an initiative to improve the UI for editors with many configuration options.

Testing instructions

This editor is used in 3 places:

  • Editing a "basic" (i.e. Text) XBlock from within a Unit
  • Editing a "basic" (i.e. Text) XBlock from within a Library
  • Editing an "advanced" (i.e. LTI Consumer) XBlock from within a Library

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 20, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 20, 2026

Thanks for the pull request, @rpenido!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 20, 2026
@rpenido rpenido force-pushed the rpenido/fal-4321/add-fullscreen-button-to-editor branch from 08a7c1e to 061f010 Compare February 20, 2026 21:14
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (c4a09a2) to head (eb54e52).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2892    +/-   ##
========================================
  Coverage   95.39%   95.39%            
========================================
  Files        1331     1331            
  Lines       30585    30595    +10     
  Branches     6713     6933   +220     
========================================
+ Hits        29177    29187    +10     
+ Misses       1351     1339    -12     
- Partials       57       69    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Feb 24, 2026
@rpenido rpenido force-pushed the rpenido/fal-4321/add-fullscreen-button-to-editor branch from 061f010 to 6a6c8cf Compare February 24, 2026 18:54
@rpenido rpenido changed the title feat: add fullscreen button to editor feat: add fullscreen button to XBlock editor Feb 24, 2026
@rpenido rpenido marked this pull request as ready for review February 24, 2026 19:34
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good. Just have one problem, the tiny-mce-editor doesn't seem to expand to take up the full space in fullscreen. I don't think it is a very simple problem as there is no clear option to dynamically resize the editor.

@rpenido
Copy link
Contributor Author

rpenido commented Feb 25, 2026

I don't think it is a very simple problem as there is no clear option to dynamically resize the editor.

I tried to fix it, but the problem is that the tiny-mce-editor sets the editor css property 'height', even if we only set the 'min_height`. I didn't find a way to fix it.

@ChrisChV
Copy link
Contributor

@rpenido It's missing a padding between the buttons

image

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are some nits to fix before merging

@rpenido
Copy link
Contributor Author

rpenido commented Feb 26, 2026

@rpenido It's missing a padding between the buttons

Thanks @ChrisChV! Fixed here: 18b33f3

@ChrisChV ChrisChV merged commit 2e62093 into openedx:master Feb 27, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Feb 27, 2026
@ChrisChV ChrisChV deleted the rpenido/fal-4321/add-fullscreen-button-to-editor branch February 27, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants