feat: add team groups section in group configurations

[BryanttV]

Description

This PR adds a new section (TeamGroupsSection) to the Group Configurations page. This section is necessary to render the Teams configured in each Group of the course when the functionality to connect Teams with Content Groups is enabled.

Supporting information

• Enabling content groups for teams breaks the content groups functionality (teams - content groups) #1698
• Backend Implementation
• Product Proposal

Screenshots

Before

After

Testing instructions

1. Create a Waffle Flag for your course in {lms_domain}/admin/waffle_utils/waffleflagcourseoverridemodel/

   • Waffle Flag: teams.content_groups_for_teams
   • Course id: [Your Course ID]
   • Enabled: ✅

2. Enables Teams in the platform using the teams.enable_teams_app flag.

3. Enable teams for your course in Studio > [Your Course] > Content > Pages & Resources > Teams > Teams toggle

4. In the same modal of Configure teams, create a few Groups.

5. Then, go to the LMS > [Your Course] > Teams and create a few Teams within those Groups (Topics/team-sets)

6. From Studio, go to Settings > Group Configurations.

7. You can see the new section for each of the groups. These sections are not editable.

8. Also, you can create Content Groups without any problem.

add-team-groups-section-in-group-configurations.webm

Additional Information

This is how it looks in the legacy interface:

teams-groups-legacy-interface.webm

[openedx-webhooks]

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (f900ace) to head (3a3981c).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
+ Coverage   95.18%   95.37%   +0.19%     
==========================================
  Files        1319     1333      +14     
  Lines       30022    30603     +581     
  Branches     6748     6944     +196     
==========================================
+ Hits        28575    29187     +612     
+ Misses       1378     1347      -31     
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[dcoa]

LGTM!!

@bradenmacdonald @PKulkoRaccoonGang @arbrandes I don't have permission over this repo, do you mind have a look to this PR?

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[PKulkoRaccoonGang]

Thanks for the PR! After some testing, I have some suggestions/observations that probably don't apply to this PR. If they don't apply to your scope of work and they are valid, I don't mind moving them to a separate issue 💯

1. If the course unit page is enabled, the link (which is under This group controls access to:) should be followed without reloading the page.
2. After I create a team I get an error with status code 500
   
3. After adding a new group, the user must manually scroll the inner content of the Configure teams modal window to the newly added group. Should the modal window content be automatically scrolled to the new group block?
   
4. Is it worth showing the icon to collapse the new group creation block if it is not possible to do so until the group is created? I think this can be a bit misleading for users.
   

[BryanttV]

Hi @PKulkoRaccoonGang! Thank you for your review, and I apologize for the delay. I was busy with other things. I've already addressed your suggestions.

Regarding what you found, I agree it should be moved to a separate issue.

FYI, the 500 error has already been reported here: openedx/openedx-platform#36841, and work is in progress to fix it.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[bradenmacdonald]

Hey everyone, what's the status of this PR?

[BryanttV]

Hi @bradenmacdonald, thanks for your comment! I made the changes requested by @PKulkoRaccoonGang. The PR is ready for re-review.

[bradenmacdonald]

@PKulkoRaccoonGang do you have time to resume your review here?

[bradenmacdonald]

@BryanttV Please reach out to me if you don't hear back from him within a few days.

[BryanttV]

Hi @bradenmacdonald! I haven't received a response yet. I'm tagging you so we can move forward.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[bradenmacdonald]

Sure @BryanttV , I'll try to review soon then. Could you please merge master into this branch or rebase on master so I'm testing it as it will be when it merges?

@crathbun428 or @jmakowski1123 could one of you confirm this is good to go from a product perspective? I can see there's been extensive discussion of the proposal but it's hard for me to tell the final decision(s) and how this aligns.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[BryanttV]

@bradenmacdonald, thanks! rebased with master ✅

[bradenmacdonald]

When testing this, I found that I'm seeing some team groups listed twice. Let me know if you need more info to debug.

The legacy UI only shows them once:

Also, I'm still unable to create a new content group. It gives the error shown below:

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[bradenmacdonald]

@BryanttV are you still planning to finish up this PR?

[BryanttV]

@bradenmacdonald, thanks for the ping! Over the last few weeks I've been catching up on some pending PRs and this one of them. I'll update it as soon as possible, sorry for the delay

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[BryanttV]

Hi @bradenmacdonald, sorry for the delay, I just made the requested changes!

I was testing, and everything works as expected. I couldn't reproduce the errors you reported. Could you check again with the new changes?

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[bradenmacdonald]

@BryanttV I will test again and review, but I haven't had much time this week. Thanks for your patience!

[bradenmacdonald]

Hmm, @BryanttV I am still seeing the bug:

Before	After

Notice the team groups with IDs 4 & 5 are listed twice. Although I see they were also listed before this PR, just without the edit buttons.

But also, even without your PR, on the master branch I cannot create new content groups:

So maybe there is a problem with my test course?

[bradenmacdonald]

Here is the JSON response from http://studio.local.openedx.io:8001/api/contentstore/v1/group_configurations/course-v1:OpenCraftX+EXAM+1 if that helps:

https://gist.github.com/bradenmacdonald/c614c08c953522687686e2899fc59eca

[BryanttV]

Hi @bradenmacdonald, thanks a lot for your review!

I was testing with a new course and was finally able to reproduce the issue. The endpoint response is correct, but the frontend logic used to obtain each group’s configuration was incorrect. I’ve fixed this in commit 3a3981c, and everything should be working correctly now.

[open-craft-grove]

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[bradenmacdonald]

Thanks for figuring that out @BryanttV ! I think this is good to go now. I'm glad we got that bug fixed.