-
Notifications
You must be signed in to change notification settings - Fork 149
feat: Open Manage tags on click tag count in section/subsection page [FC-0090] #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Open Manage tags on click tag count in section/subsection page [FC-0090] #2136
Conversation
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
+ Coverage 94.11% 94.12% +0.01%
==========================================
Files 1164 1164
Lines 24507 24527 +20
Branches 5201 5320 +119
==========================================
+ Hits 23065 23087 +22
+ Misses 1374 1363 -11
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/library-authoring/section-subsections/LibrarySectionSubsectionPage.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is working well (so long as I refresh the container page), but I left some suggestions on the tests.
Oddly, since we use the search index when showing container cards, its tag counts update immediately, but not so for the queries using the container API. Maybe we need a similar kind of cache clearing for these hits too?
- I tested this: (describe what you tested)
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
-
User-facing strings are extracted for translationN/A
src/library-authoring/section-subsections/LibrarySectionSubsectionPage.test.tsx
Outdated
Show resolved
Hide resolved
src/library-authoring/section-subsections/LibrarySectionSubsectionPage.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, but not a blocker.
const scheduleJumpToTags = useRunOnNextRender(() => { | ||
// TODO: Ugly hack to make sure sidebar shows manage tags section | ||
// This needs to run after all changes to url takes place to avoid conflicts. | ||
setTimeout(() => setSidebarAction(SidebarActions.JumpToManageTags), 250); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I wish there were a better way to do this. I see we're already using it in a few other places.
What is the reason we can't just do something like
navigateTo({ selectedItemId: container.originalId, sidebarAction: SidebarActions.JumpToManageTags });
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on this in open-craft#91
Description
Supporting information
tags_count
toContainerMetadata
[FC-0090] edx-platform#36883Testing instructions
Other information