Skip to content

[Teak] style: Fixing nits about sync units [FC-0097] #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/teak
Choose a base branch
from

Conversation

ChrisChV
Copy link
Contributor

Description

Backport of #2319

Supporting information

Testing instructions

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 22, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jul 22, 2025
@ChrisChV ChrisChV force-pushed the chris/teak/unit-library-sync-nits branch from 457b995 to f4a92f7 Compare July 22, 2025 20:11
@ChrisChV ChrisChV requested a review from bradenmacdonald July 22, 2025 20:12
@ChrisChV ChrisChV changed the title style: Fixing nits about sync units [FC-0097] [Teak] style: Fixing nits about sync units [FC-0097] Jul 22, 2025
* Stay visible the sync icon in the course outline
* Update the message in the sync unit modal
* Add warning banner about units in the libraries sync page
@ChrisChV ChrisChV force-pushed the chris/teak/unit-library-sync-nits branch from f4a92f7 to 8dfc215 Compare July 22, 2025 20:32
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/teak@4bc34c2). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/teak    #2320   +/-   ##
===============================================
  Coverage                ?   93.89%           
===============================================
  Files                   ?     1149           
  Lines                   ?    24089           
  Branches                ?     5195           
===============================================
  Hits                    ?    22618           
  Misses                  ?     1403           
  Partials                ?       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. FC Relates to an Axim Funded Contribution project labels Jul 28, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants