Replace connect with useSelector() and useDispatch() 2/5 #2314

[ahtesham-quraish]

Description

Replace connect with useSelector() and useDispatch() 2/5 #2314

Supporting information

Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for manually testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

• Does this change depend on other changes elsewhere?
• Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

• Any new files are using TypeScript (.ts, .tsx).
• Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
• Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
• Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
• Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
• All new i18n messages in messages.ts files have a description for translators to use.
• Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.45%. Comparing base (0e1550a) to head (eb476c8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2333   +/-   ##
=======================================
  Coverage   94.44%   94.45%           
=======================================
  Files        1169     1169           
  Lines       25102    25130   +28     
  Branches     5473     5490   +17     
=======================================
+ Hits        23708    23736   +28     
+ Misses       1328     1322    -6     
- Partials       66       72    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Faraz32123]

Can we remove this or any unnecessary comments?

[ahtesham-quraish]

removed

[bradenmacdonald]

Thanks for this! It's a nice refactor and I'm excited to have this in place. However, could you please make sure to review #2343 and rebase this on top of it, before proceeding?

[bradenmacdonald]

Passing initialState twice (to initializeMocks and editorRender) is redundant - please see the fixes in #2343

[ahtesham-quraish]

I have removed the initialState from initializeMocks

[bradenmacdonald]

Please declare this using the EditorState type (or PartialEditorState from #2343) so we know that the types are valid. I suspect there are some issues here.

[ahtesham-quraish]

I have used the PartialEditorState from #2343 you can check that

[ahtesham-quraish]

@bradenmacdonald thank you for highlighting the typed issues I have tried to fix them in my current PR and will fix the remaining ones in follow-up PRs. I have gone through the #2343 and approved it, after its merge I will rebase my branch

[bradenmacdonald]

Thanks @ahtesham-quraish. I've merged it now so you can rebase this branch.

[ahtesham-quraish]

@bradenmacdonald I have rebased my branch with #2343 please re-review my PR